Review main Merged

87234[BUGFIX] Use migrated connection `defaultTableOptions` in `EXT:reports`

Stefan Bürk CR +2 V +2 Easy +10 −9 updated 11/26/24, 16:01

Commit message

The `EXT:reports` module generates a report based on different checks
to provide an overview over the TYPO3 installation including database
related checks for the charset and collation and is based on the raw
global database configuration.

TYPO3 used an connection `tableoptions` sub array for collation and
charset configuration when creating database tables. Since Doctrine
DBAL provides the same feature with an `defaultTableOptions` database
connection configuration this is migrated silently within the TYPO3
ConnectionPool when creating a connection.

Further, Doctrine DBAL switched defaultTableOptions option name from
`collate` to `collation` with 3.x and dropped the old completly with
4.x which is also covered by the added migation and deprecation with
change #105297.

The migration is applied only locally to be used for the connection
and not on the global raw configuration and the `EXT:resports` check
does not retrieve the correct values due to this reason.

This change now uses the migrated connection configuration parameter
information within the `EXT:reports` module to use the final migrated
values to process the checks and closes the oversight within #105297.
Fallback handling in `ConnectionMigrator` is removed due to beeing
obsolete based on the migration.

Note choosen solution is deprecataion removal safe and does not need
adoption when removing the deprecated migration.

[1] https://github.com/doctrine/dbal/pull/5246

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Stefan Bürk uploaded patch set 1 11/26/24, 09:28

  2. core-ci voted on patch set 1 V +1 11/26/24, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70198

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 11/26/24, 12:26

  4. Anja Leichsenring voted on patch set 1 CR +1 V +1 11/26/24, 14:54

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 11/26/24, 15:03

  6. Stefan Bürk merged patch set 2 11/26/24, 16:01