Review main Merged

87235[BUGFIX] Avoid copying workspace delete placeholder

Christian Kuhn CR +2 V +2 Hard +405 −1 updated 11/26/24, 16:59

Commit message

The tests replay the reported scenario: A live content
element with two images is manipulated in workspaces
by deleting one attached image (creating a delete
placeholder, t3ver_state 2) and adding another one
(creating a workspace-new record t3ver_state 1).
The content element is then copied in workspaces.

The tests verify the delete placeholder is ignored
and copied along with the other attached images,
when the fix within DataHandler is not applied.
This makes the deleted attached image magically
pop up again in the copied content element.

The patch fixes this with a straight condition
within DataHandler copyRecord() to suppress
creating copies of records that have a delete
placeholder overlay in this workspace.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 1116

  1. Christian Kuhn uploaded patch set 1 11/26/24, 13:32

  2. Christian Kuhn commented on patch set 1 11/26/24, 13:38

    patch set 1 verifies the issue is correct: the delete placeholder for a image reference is turned into a workspace-new record on copy.
  3. core-ci voted on patch set 1 V +1 11/26/24, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70203

  4. Christian Kuhn uploaded patch set 2 V +1 11/26/24, 14:09

  5. Christian Kuhn uploaded patch set 3 11/26/24, 14:14

  6. core-ci voted on patch set 2 V +1 11/26/24, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70204

  7. core-ci voted on patch set 3 V +1 11/26/24, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70205

  8. Christian Kuhn uploaded patch set 4 V +1 11/26/24, 15:00

  9. core-ci voted on patch set 4 V +1 11/26/24, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70206

  10. Christian Kuhn updated the commit message in patch set 5 V +1 11/26/24, 15:07

  11. core-ci voted on patch set 5 V +1 11/26/24, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70208

  12. Stefan Bürk voted on patch set 5 CR +1 11/26/24, 15:59

  13. Stefan Bürk voted on patch set 5 V +1 11/26/24, 16:28

  14. Garvin Hicking voted on patch set 5 CR +1 V +1 11/26/24, 16:48

  15. Christian Kuhn voted on patch set 5 CR +2 V +2 11/26/24, 16:59

  16. Christian Kuhn merged patch set 6 11/26/24, 16:59