87235[BUGFIX] Avoid copying workspace delete placeholder
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 12
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/Modify/DataSet/modifyContentDeleteFileRefAddFileRefCopyElement.csvnew+57 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/Modify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/WorkspacesDiscard/DataSet/modifyContentDeleteFileRefAddFileRefCopyElement.csvnew+64 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/WorkspacesDiscard/ActionTest.php+9 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/WorkspacesModify/DataSet/modifyContentDeleteFileRefAddFileRefCopyElement.csvnew+71 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/WorkspacesModify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/WorkspacesPublish/DataSet/modifyContentDeleteFileRefAddFileRefCopyElement.csvnew+71 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/WorkspacesPublish/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/WorkspacesPublishAll/DataSet/modifyContentDeleteFileRefAddFileRefCopyElement.csvnew+62 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/WorkspacesPublishAll/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/AbstractActionTestCase.php+34 −1
Review log 1116
-
Christian Kuhn uploaded patch set 1 11/26/24, 13:32
-
Christian Kuhn commented on patch set 1 11/26/24, 13:38
patch set 1 verifies the issue is correct: the delete placeholder for a image reference is turned into a workspace-new record on copy. -
core-ci voted on patch set 1 V +1 11/26/24, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70203
-
Christian Kuhn uploaded patch set 2
V +111/26/24, 14:09 -
Christian Kuhn uploaded patch set 3 11/26/24, 14:14
-
core-ci voted on patch set 2 V +1 11/26/24, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70204
-
core-ci voted on patch set 3 V +1 11/26/24, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70205
-
Christian Kuhn uploaded patch set 4
V +111/26/24, 15:00 -
core-ci voted on patch set 4 V +1 11/26/24, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70206
-
Christian Kuhn updated the commit message in patch set 5
V +111/26/24, 15:07 -
core-ci voted on patch set 5 V +1 11/26/24, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70208
-
Stefan Bürk voted on patch set 5 CR +1 11/26/24, 15:59
-
Stefan Bürk voted on patch set 5 V +1 11/26/24, 16:28
-
Garvin Hicking voted on patch set 5 CR +1 V +1 11/26/24, 16:48
-
Christian Kuhn voted on patch set 5 CR +2 V +2 11/26/24, 16:59
-
Christian Kuhn merged patch set 6 11/26/24, 16:59