Review 12.4 Merged

87238[BUGFIX] Avoid copying workspace delete placeholder

Christian Kuhn CR +2 V +2 Hard +405 −1 updated 11/26/24, 16:59

Commit message

The tests replay the reported scenario: A live content
element with two images is manipulated in workspaces
by deleting one attached image (creating a delete
placeholder, t3ver_state 2) and adding another one
(creating a workspace-new record t3ver_state 1).
The content element is then copied in workspaces.

The tests verify the delete placeholder is ignored
and copied along with the other attached images,
when the fix within DataHandler is not applied.
This makes the deleted attached image magically
pop up again in the copied content element.

The patch fixes this with a straight condition
within DataHandler copyRecord() to suppress
creating copies of records that have a delete
placeholder overlay in this workspace.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 12

Review log 34

  1. Christian Kuhn uploaded patch set 1 11/26/24, 15:47

  2. core-ci voted on patch set 1 V +1 11/26/24, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70210

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 11/26/24, 16:59

  4. Christian Kuhn merged patch set 2 11/26/24, 16:59