87240[TASK] Enable AVIF support for ImageMagick
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Chris Müller +1
- Simon Schaufelberger +1
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Chris Müller +1
- Simon Schaufelberger +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php3+35 −7
- typo3/sysext/core/Classes/Imaging/ImageMagickFile.php+2 −1
- typo3/sysext/core/Configuration/DefaultConfiguration.php+2 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageViewHelperTest.php+15 −0
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+76 −3
- typo3/sysext/install/Resources/Private/Templates/Environment/ImageProcessing.html+34 −19
- typo3/sysext/install/Resources/Public/Images/TestReference/Convert-avif.avifnewbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Read-avif.jpgnewbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Write-avif.avifnewbinary
- typo3/sysext/reports/Classes/Report/Status/ImageProcessingStatus.php+34 −14
- typo3/sysext/reports/Resources/Private/Language/locallang_reports.xlf+15 −0
Review log 3447
Show 1322 earlier messages
-
Garvin Hicking uploaded patch set 1 11/26/24, 16:43
-
core-ci voted on patch set 1 V -1 11/26/24, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70215
-
Garvin Hicking uploaded patch set 2
V -111/26/24, 17:00CGL -
core-ci voted on patch set 2 V -1 11/26/24, 17:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70216
-
Garvin Hicking uploaded patch set 3
V -111/27/24, 10:03Fix mime type detection -
core-ci voted on patch set 3 V +1 11/27/24, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70244
-
Garvin Hicking uploaded patch set 4
V +111/27/24, 10:32Disable whole test until updated -
core-ci voted on patch set 4 V +1 11/27/24, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70247
-
Benni Mack commented on patch set 4 11/28/24, 10:57
please have a call about this -
Garvin Hicking uploaded patch set 5
V +112/05/24, 09:16 -
Garvin Hicking rebased onto patch set 6 12/05/24, 09:18
-
core-ci voted on patch set 6 V +1 12/05/24, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70635
-
core-ci voted on patch set 5 V -1 12/05/24, 09:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70632
-
Garvin Hicking updated the commit message in patch set 7
V +112/05/24, 10:31 -
core-ci voted on patch set 7 V +1 12/05/24, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70638
-
Garvin Hicking updated the commit message in patch set 8
V +112/11/24, 11:13 -
core-ci voted on patch set 8 V +1 12/11/24, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70914
-
Garvin Hicking updated the commit message in patch set 9
V +112/11/24, 11:28 -
core-ci voted on patch set 9 V +1 12/11/24, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70921
-
Benni Mack voted on patch set 9 CR +1 V +1 12/11/24, 11:47
-
Simon Schaufelberger commented on patch set 9 CR -1 12/12/24, 12:29
on it -
Simon Schaufelberger uploaded patch set 10
CR +1V +112/12/24, 13:06
-
Simon Schaufelberger voted on patch set 10 CR +1 V +1 12/12/24, 13:07
-
core-ci voted on patch set 10 V +1 12/12/24, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71029
-
Benni Mack voted on patch set 10 CR +1 V +1 12/13/24, 17:02
-
Guido Schmechel voted on patch set 10 CR +1 V +1 12/13/24, 20:30
-
Chris Müller commented on patch set 10 V -1 12/17/24, 12:15
The reference image for "Read avif" is broken in my installation. It is a data: URL without a value: <img class="reference" src="data:image/jpg;base64,"> -
Chris Müller commented on patch set 10 12/17/24, 12:16
Reply
Same for "Write avif" and "jpg to avif" -
Chris Müller commented on patch set 10 V 0 12/17/24, 12:32
Reply
Okay, resolved. Applied the patch with Gilbertsoft's patch package, seems that binaries are not correctly processed. -
Garvin Hicking uploaded patch set 11
CR +1V +112/17/24, 13:11Make sure to skip test when unvavailable -
Garvin Hicking commented on patch set 11 12/17/24, 13:13
Reply
Thank you for testing this, and finding out that the error messages when AVIF writing did not work were misleading, and not showing the 'soft fail' message. The other more generic message has also been updated to reflect the need for specific codes. -
core-ci voted on patch set 11 V +1 12/17/24, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71270
-
Chris Müller voted on patch set 11 CR +1 V +1 12/17/24, 13:47
-
Garvin Hicking uploaded patch set 12
CR +1V +112/17/24, 14:08 -
core-ci voted on patch set 12 V +1 12/17/24, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71278
-
Chris Müller voted on patch set 12 CR +1 V +1 12/17/24, 14:18
-
Simon Schaufelberger voted on patch set 12 CR +1 V +1 12/17/24, 15:04
-
Garvin Hicking commented on patch set 13
CR +1V +112/17/24, 15:17Published edit on patch set 12. -
core-ci voted on patch set 13 V +1 12/17/24, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71288
-
Benni Mack voted on patch set 13 CR +1 V +1 12/17/24, 15:28
-
Simon Schaufelberger voted on patch set 13 CR +1 V +1 12/17/24, 15:29
-
Chris Müller voted on patch set 13 CR +1 V +1 12/18/24, 17:31
-
Garvin Hicking voted on patch set 13 CR +2 V +2 12/18/24, 17:47
-
Garvin Hicking merged patch set 14 12/18/24, 17:47
-
Sebastian Iffland commented on patch set 14 12/18/24, 18:06
GraphicalFunctions.php:333Feeling a bit lost… maybe too late, maybe someone could clarify. If I read right, this `elseif` construct can never be reached since 'avif' is listed in `$this->webImageExt` (L98), which then means it is in_array and the starting if is being processed. -
Simon Schaufelberger commented on patch set 14 12/18/24, 18:16
GraphicalFunctions.php:333Replyindeed, it seams like this can be dropped. -
Garvin Hicking commented on patch set 14 12/19/24, 09:09
GraphicalFunctions.php:333ReplyGood point. The isAvailable check however should be performed, so this logic needs to be massaged a bit. I'll address this in a follow-up. Please see https://review.typo3.org/c/Packages/TYPO3.CMS/+/87567