Review 13.4 Merged

87242[TASK] Use phpunit DoesNotPerformAssertions attribute

Christian Kuhn CR +2 V +2 Normal +63 −102 updated 11/27/24, 07:55

Commit message

There are valid cases where tests do not assert
anything and still test some subject functionality.

Tests without assertions are however often developer
oversights, so phpunit warns about them, which is
disabled via phpunit configuration currently.

The patch enables this configuration, removes some
dummy assertions, and uses #[DoesNotPerformAssertions]
to mark legit cases for phpunit to stop mumbling.

The patch requires a typo3/testing-framework raise:
> composer req --dev typo3/testing-framework:^9.0.2

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 21

Show 1 more file

Review log 813

  1. Christian Kuhn uploaded patch set 1 11/26/24, 21:11

  2. Christian Kuhn uploaded patch set 2 11/26/24, 21:19

  3. core-ci voted on patch set 1 V -1 11/26/24, 21:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70221

  4. core-ci voted on patch set 2 V -1 11/26/24, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70223

  5. Christian Kuhn uploaded patch set 3 V -1 11/26/24, 21:30

  6. core-ci voted on patch set 3 V +1 11/26/24, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70224

  7. Christian Kuhn uploaded patch set 4 V +1 11/26/24, 21:42

  8. core-ci voted on patch set 4 V +1 11/26/24, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70225

  9. Christian Kuhn updated the commit message in patch set 5 V +1 11/26/24, 21:59

  10. core-ci voted on patch set 5 V +1 11/26/24, 22:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70228

  11. Stefan Bürk voted on patch set 5 CR +1 V +1 11/27/24, 07:40

  12. Christian Kuhn voted on patch set 5 CR +2 V +2 11/27/24, 07:54

  13. Christian Kuhn merged patch set 6 11/27/24, 07:55