Review main Merged

87254[BUGFIX] Prevent undefined array key errors in TcaSelectItems

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 12/04/24, 12:53

Commit message

This adjust `TcaSelectItems` to prevent some
undefined array key errors.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1217

  1. Oli Bartsch uploaded patch set 1 11/27/24, 11:23

  2. core-ci voted on patch set 1 V +1 11/27/24, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70253

  3. Oliver Klee updated the commit message in patch set 2 V +1 11/28/24, 10:11

  4. core-ci voted on patch set 2 V +1 11/28/24, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70299

  5. Lina Wolf commented on patch set 2 CR +1 12/03/24, 17:12

    thanks a lot, looks good to me
  6. Garvin Hicking commented on patch set 2 CR +1 V +1 12/03/24, 19:29

    TcaSelectItems.php:47

    ```suggestion // Make sure we do not process "selectTree" renderType ```
  7. Benni Mack commented on patch set 3 CR +1 V +1 12/04/24, 09:36

    Published edit on patch set 2.
  8. Benni Mack commented on patch set 3 12/04/24, 09:36

    TcaSelectItems.php:47 Reply

    Done
  9. Oli Bartsch uploaded patch set 4 12/04/24, 09:40

  10. core-ci voted on patch set 3 V +1 12/04/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70573

  11. Oli Bartsch uploaded patch set 5 12/04/24, 09:44

  12. Garvin Hicking voted on patch set 5 CR +1 V +1 12/04/24, 09:48

  13. core-ci voted on patch set 5 V +1 12/04/24, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70575

  14. core-ci voted on patch set 4 V -1 12/04/24, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70574

  15. Benni Mack voted on patch set 5 CR +1 V +1 12/04/24, 10:01

  16. Oli Bartsch voted on patch set 5 CR +2 V +2 12/04/24, 12:53

  17. Oli Bartsch merged patch set 6 12/04/24, 12:53