Review main Merged

87260[TASK] Resolve phpstan property.unusedType

Christian Kuhn CR +2 V +2 Normal +14 −77 updated 11/28/24, 08:31

Commit message

harden "too wide" property definitions phpstan
mumbles about: In tests, phpstan understands that
a property can not be null if it is set within
setUp(). In code, some properties can be turned
into constructor property promotion, or are
initialized to null.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 810

  1. Christian Kuhn uploaded patch set 1 11/27/24, 18:51

  2. Christian Kuhn uploaded patch set 2 11/27/24, 18:54

  3. core-ci voted on patch set 1 V -1 11/27/24, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70268

  4. core-ci voted on patch set 2 V +1 11/27/24, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70269

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 11/27/24, 19:37

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 11/27/24, 20:19

  7. Garvin Hicking voted on patch set 2 CR +2 V +2 11/27/24, 22:25

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 11/27/24, 22:25

  9. Christian Kuhn voted on patch set 2 CR +2 V +2 11/28/24, 08:31

  10. Christian Kuhn merged patch set 3 11/28/24, 08:31