Review main Merged

87274[BUGFIX] Validate $elementRecord before accessing children

André Buchmann CR +2 V +2 Easy +1 −1 updated 12/03/24, 16:34

Commit message

The sendToSpecificStageExecute method checks for already published
records by using BackendUtility::getRecord(). However this method
returns null when no matching record is found. We now validate the
result before accessing the array.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. André Buchmann uploaded patch set 1 11/28/24, 13:52

  2. core-ci voted on patch set 1 V +1 11/28/24, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70305

  3. Oli Bartsch commented on patch set 1 12/01/24, 16:28

    ActionHandler.php:591

    Suggest to change this line to: ``` if ((int)($elementRecord['t3ver_wsid'] ?? 0) === 0) { ```
  4. Christian Kuhn uploaded patch set 2 V +1 12/03/24, 12:54

  5. Christian Kuhn commented on patch set 1 12/03/24, 12:54

    ActionHandler.php:591 Reply

    kinda matter of taste, but done.
  6. Christian Kuhn voted on patch set 2 CR +1 V +1 12/03/24, 12:54

  7. Anja Leichsenring voted on patch set 2 CR +1 V +1 12/03/24, 12:56

  8. core-ci voted on patch set 2 V +1 12/03/24, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70533

  9. Christian Kuhn voted on patch set 2 CR +2 V +2 12/03/24, 16:34

  10. Christian Kuhn merged patch set 3 12/03/24, 16:34