87278[TASK] Resolve many phpstan staticMethod.alreadyNarrowedType findings
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Anja Leichsenring +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 58
- Build/phpstan/phpstan-baseline.neon+0 −372
- typo3/sysext/backend/Classes/ElementBrowser/ElementBrowserRegistry.php+0 −1
- typo3/sysext/backend/Tests/Unit/ElementBrowser/ElementBrowserRegistryTest.php+0 −3
- typo3/sysext/core/Classes/Console/CommandRegistry.php+5 −11
- typo3/sysext/core/Classes/Crypto/PasswordHashing/BcryptPasswordHash.php+0 −3
- typo3/sysext/core/Classes/Mail/MailMessage.php+3 −0
- typo3/sysext/core/Classes/Resource/FileReference.php+3 −10
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −2
- typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php+1 −4
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/PositionPlaceholderPreparedStatementTest.php+8 −16
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+1 −2
- typo3/sysext/core/Tests/Functional/DataHandling/RecordFieldTransformerTest.php+0 −2
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php+0 −9
- typo3/sysext/core/Tests/Functional/Hooks/TcaItemsProcessorFunctionsTest.php+0 −1
- typo3/sysext/core/Tests/Functional/Resource/Driver/LocalDriverTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Console/CommandRegistryTest.php+3 −20
- typo3/sysext/core/Tests/Unit/Context/SecurityAspectTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Argon2idPasswordHashTest.php+34 −32
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Argon2iPasswordHashTest.php+34 −35
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/BcryptPasswordHashTest.php+39 −38
Show 38 more files
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/ExpressionBuilderTest.php+0 −4
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ReferenceDefinitionTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php+1 −6
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/MySQLSchemaManagerTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/PostgreSQLSchemaManagerTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/SQLiteSchemaManagerTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Database/ConnectionTest.php+4 −3
- typo3/sysext/core/Tests/Unit/DataHandling/Localization/StateTest.php+32 −45
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+0 −6
- typo3/sysext/core/Tests/Unit/DependencyInjection/ConsoleCommandPassTest.php+1 −2
- typo3/sysext/core/Tests/Unit/DependencyInjection/FailsafeContainerTest.php+4 −2
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderCompilationPassTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderRegistryTest.php+4 −3
- typo3/sysext/core/Tests/Unit/EventDispatcher/EventDispatcherTest.php+47 −64
- typo3/sysext/core/Tests/Unit/EventDispatcher/NoopEventDispatcherTest.php+0 −7
- typo3/sysext/core/Tests/Unit/Http/ApplicationTypeTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Http/ClientTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Http/RequestFactoryTest.php+0 −14
- typo3/sysext/core/Tests/Unit/Http/ResponseFactoryTest.php+0 −11
- typo3/sysext/core/Tests/Unit/Http/ServerRequestFactoryTest.php+0 −16
- typo3/sysext/core/Tests/Unit/Http/StreamFactoryTest.php+2 −13
- typo3/sysext/core/Tests/Unit/Http/StreamTest.php+7 −6
- typo3/sysext/core/Tests/Unit/Http/UploadedFileFactoryTest.php+0 −11
- typo3/sysext/core/Tests/Unit/Http/UriFactoryTest.php+0 −14
- typo3/sysext/core/Tests/Unit/Imaging/ImageManipulation/CropVariantCollectionTest.php+3 −5
- typo3/sysext/core/Tests/Unit/Imaging/ImageManipulation/CropVariantTest.php+13 −14
- typo3/sysext/core/Tests/Unit/Imaging/DimensionTest.php+4 −19
- typo3/sysext/core/Tests/Unit/Imaging/IconRegistryTest.php+0 −7
- typo3/sysext/core/Tests/Unit/Log/LogManagerTest.php+0 −7
- typo3/sysext/core/Tests/Unit/Mail/MailMessageTest.php+65 −59
- typo3/sysext/core/Tests/Unit/Mail/TransportFactoryTest.php+3 −4
- typo3/sysext/core/Tests/Unit/Messaging/FlashMessageRendererResolverTest.php+4 −3
- typo3/sysext/core/Tests/Unit/Site/Entity/SiteTest.php+2 −3
- typo3/sysext/core/Tests/Unit/Type/File/ImageInfoTest.php+0 −10
- typo3/sysext/core/Tests/Unit/Type/MapTest.php+0 −1
- typo3/sysext/core/Tests/Unit/TypoScript/AST/Node/ChildNodeTest.php+1 −1
- typo3/sysext/core/Tests/Unit/TypoScript/AST/Node/ReferenceChildNodeTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+6 −6
Review log 1423
-
Christian Kuhn uploaded patch set 1 11/28/24, 20:25
-
core-ci voted on patch set 1 V +1 11/28/24, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70315
-
Christian Kuhn uploaded patch set 2
V +111/29/24, 09:44 -
core-ci voted on patch set 2 V -1 11/29/24, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70345
-
Christian Kuhn uploaded patch set 3
V -111/29/24, 10:09 -
core-ci voted on patch set 3 V +1 11/29/24, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70346
-
Christian Kuhn rebased onto patch set 4
V +112/02/24, 10:45 -
core-ci voted on patch set 4 V -1 12/02/24, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70447
-
Christian Kuhn uploaded patch set 5
V -112/02/24, 11:44 -
core-ci voted on patch set 5 V +1 12/02/24, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70453
-
Christian Kuhn uploaded patch set 6
V +112/02/24, 12:29 -
core-ci voted on patch set 6 V -1 12/02/24, 12:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70456
-
Christian Kuhn uploaded patch set 7
V -112/02/24, 13:08 -
core-ci voted on patch set 7 V -1 12/02/24, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70457
-
Christian Kuhn uploaded patch set 8
V -112/02/24, 13:44 -
Christian Kuhn updated the commit message in patch set 9 12/02/24, 13:46
-
core-ci voted on patch set 8 V +1 12/02/24, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70458
-
core-ci voted on patch set 9 V +1 12/02/24, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70459
-
Anja Leichsenring voted on patch set 9 CR +1 V +1 12/02/24, 14:03
-
Stefan Bürk voted on patch set 9 CR +1 V +1 12/02/24, 14:14
-
Markus Klein voted on patch set 9 CR +1 V +1 12/02/24, 14:18
-
Christian Kuhn voted on patch set 9 CR +2 V +2 12/02/24, 14:23
-
Christian Kuhn merged patch set 10 12/02/24, 14:23