Review 12.4 Merged

87279[BUGFIX] Streamline midnight vs null handling of time fields

Benjamin Franzke CR +2 V +2 Hard +793 −56 updated 12/06/24, 09:11

Commit message

* Treat 00:00(:00) as valid time for nullable native time fields
   (has been misinterpreted as an empty-value before)

 * Treat database value 0 as empty for non-nullable integer-based
   time fields (has not been differentiated from nullable fields before)

 * Treat an empty date-input value as NULL in DataHandler if the field
   is nullable (same result as unchecking the "Set value" checkbox)

 * Add testcases for non-nullable date/datetime/time(sec) fields
   with – nowadays invalid – zero dates 0000-00-00
   (testcases rely on mariadb safe mode NO_ZERO_DATE to be disabled
   and are therefore tested in a seperate functional testcase)

Note: 00:00:00 handling for time fields has previously been fixed in v12
by #97216, but was effectively broken with #92900, which changed the
reset value to 00:00:00 (which is the db-native empty value) instead of
a value that is intended to be understood by formengine (which used to
be timestamp integers, but is ISO8601 nowadays).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 26

Show 6 more files

Review log 610

  1. Benjamin Franzke uploaded patch set 1 11/28/24, 22:12

  2. core-ci voted on patch set 1 V -1 11/28/24, 22:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70320

  3. Benjamin Franzke uploaded patch set 2 V -1 11/29/24, 06:04

  4. core-ci voted on patch set 2 V -1 11/29/24, 06:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70338

  5. Benjamin Franzke uploaded patch set 3 V -1 11/29/24, 07:19

  6. core-ci voted on patch set 3 V +1 11/29/24, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70339

  7. Benjamin Franzke uploaded patch set 4 V +1 12/05/24, 09:49

  8. core-ci voted on patch set 4 V +1 12/05/24, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70637

  9. Benjamin Franzke commented on patch set 4 CR +2 V +2 12/06/24, 09:05

    This change is ready for review.
  10. Benjamin Franzke merged patch set 5 12/06/24, 09:11