87279[BUGFIX] Streamline midnight vs null handling of time fields
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
-
Verified V +2 Done
- Benjamin Franzke +2
- core-ci +1 CI
Issues 1
Files 26
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php+2 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowDateTimeFields.php+31 −10
- typo3/sysext/backend/Tests/Unit/Form/Element/DatetimeElementTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRowDateTimeFieldsTest.php+87 −7
- typo3/sysext/core/Classes/Database/Query/QueryHelper.php+1 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/CategoryTreeCest.php+9 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputDateCest.php+278 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/Base.csvnew+5 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/Result.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultBerlinFakeUTC0.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultBerlinLocaltime.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultEmpty.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultNull.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultOffsetBerlin.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultOffsetUTC.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultEmpty.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultNull.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DatetimeLegacyTest.phpnew+126 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DatetimeTest.php+0 −4
Show 6 more files
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_datetime/Configuration/TCA/tx_testdatahandler_datetime.php+4 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_datetime_legacy/Configuration/TCA/tx_testdatahandler_datetime_legacy.phpnew+106 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_datetime_legacy/composer.jsonnew+14 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_datetime_legacy/ext_emconf.phpnew+19 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_datetime_legacy/ext_tables.sqlnew+11 −0
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+36 −27
Review log 610
-
Benjamin Franzke uploaded patch set 1 11/28/24, 22:12
-
core-ci voted on patch set 1 V -1 11/28/24, 22:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70320
-
Benjamin Franzke uploaded patch set 2
V -111/29/24, 06:04 -
core-ci voted on patch set 2 V -1 11/29/24, 06:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70338
-
Benjamin Franzke uploaded patch set 3
V -111/29/24, 07:19 -
core-ci voted on patch set 3 V +1 11/29/24, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70339
-
Benjamin Franzke uploaded patch set 4
V +112/05/24, 09:49 -
core-ci voted on patch set 4 V +1 12/05/24, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70637
-
Benjamin Franzke commented on patch set 4 CR +2 V +2 12/06/24, 09:05
This change is ready for review. -
Benjamin Franzke merged patch set 5 12/06/24, 09:11