Review main Merged

87280[TASK] Use default `redirects.hitCount` setting in acceptance test

Stefan Bürk CR +2 V +2 Easy +10 −6 updated 11/29/24, 09:10

Commit message

Composer mode acceptance tests has been introduced with #103297,
including a conditional check for the `redirects.hitCount` based
on the environment (classic or composer mode) required due to the
fact that typo3/testing-framework sets this toggle to `true`.

Valid request has been made to remove the toggle setting from the
typo3/testing-framework setup [1].

This change removes the codeception conditional based checkbox check
and resets the `redirects.hitCount` toggle to the default value as a
temporary solution.

After removing enabling this toggle in the testing-framework and
relasing this, the temporary solution can be removed again.

[1] https://github.com/TYPO3/testing-framework/issues/554

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Stefan Bürk uploaded patch set 1 11/29/24, 08:53

  2. core-ci voted on patch set 1 V +1 11/29/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70341

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 11/29/24, 09:03

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 11/29/24, 09:08

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 11/29/24, 09:10

  6. Stefan Bürk merged patch set 2 11/29/24, 09:10