Review main Merged Breaking

87288[!!!][TASK] Stop guessing pid in extbase BackendConfigurationManager

Christian Kuhn CR +2 V +2 Hard +116 −176 updated 12/01/24, 01:34

Commit message

Stop guessing a page in extbase BackendConfigurationmanager
with extbase based backend modules not in page context.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 4

Files 3

Review log 1215

  1. Christian Kuhn uploaded patch set 1 11/29/24, 11:40

  2. core-ci voted on patch set 1 V +1 11/29/24, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70356

  3. Christian Kuhn uploaded patch set 2 V +1 11/29/24, 13:33

  4. core-ci voted on patch set 2 V +1 11/29/24, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70357

  5. Garvin Hicking commented on patch set 2 11/29/24, 20:51

    Breaking-105728-ExtbaseBackendModulesDoNotGuessPageIdForTypoScriptAnymore.rst:37

    ```suggestion from "global" TypoScript only and stop calculating TypoScript from guessing "the first valid" page. ```

    Breaking-105728-ExtbaseBackendModulesDoNotGuessPageIdForTypoScriptAnymore.rst:66

    ```suggestion .. code-block:: php ```
  6. Christian Kuhn commented on patch set 2 11/30/24, 08:30

    Breaking-105728-ExtbaseBackendModulesDoNotGuessPageIdForTypoScriptAnymore.rst:37 Reply

    Done

    Breaking-105728-ExtbaseBackendModulesDoNotGuessPageIdForTypoScriptAnymore.rst:66 Reply

    Done
  7. Christian Kuhn uploaded patch set 3 V +1 11/30/24, 08:30

  8. core-ci voted on patch set 3 V +1 11/30/24, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70376

  9. Anja Leichsenring voted on patch set 3 CR +1 V +1 11/30/24, 09:20

  10. Markus Klein commented on patch set 3 CR -1 11/30/24, 13:15

    intermediate -1. While I fully know the issue, we rely on such configuration within our extensions. I want to check, how this change affects them and how we can configure them better. Thanks for your patience.
  11. Christian Kuhn commented on patch set 3 11/30/24, 14:01

    Reply

    ext:form does this already and has been adapted including v13 to follow, see related issues. following this is the only sane way to finally get rid of this madness. note the guessing became even more unacceptable with the introduction of site sets, which don't load ext_conf_template anymore.
  12. Stefan Bürk voted on patch set 3 CR +1 V +1 11/30/24, 14:22

  13. Markus Klein commented on patch set 3 CR +1 11/30/24, 20:57

    Reply

    I was rather thinking of replacing the guesswork through some explicit config. example use case of ours: We have 2 BE modules, not using the page tree. We define multiple storagePids, which are relevant for FE **and** BE. Of course we wanna have this config in only one place. (DRY) So I still need to figure out how we can achieve that. Probably it best solution will be a dedicated Backend Middleware that injects the "id" into the request on which our TS resides.
  14. Christian Kuhn commented on patch set 3 CR +2 V +2 12/01/24, 01:34

    Reply

    i see. thanks for feedback and resolving!
  15. Christian Kuhn merged patch set 4 12/01/24, 01:34