Review main Merged

87289[TASK] Raise typo3/testing-framework

Christian Kuhn CR +2 V +2 Hard +297 −484 updated 11/30/24, 16:17

Commit message

New TF does not raise assertions in tearDown() anymore [1]
which makes phpunit detect more unit tests that don't
assert something. Some affected tests are legit and receive
the #[DoesNotPerformAssertions] attribute. Some others
were actually broken and are fixed to for instance now
expect calls on mocks. Further minor cleanups along the
way.

> composer u typo3/testing-framework

[1] https://github.com/TYPO3/testing-framework/pull/660

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 1424

  1. Christian Kuhn uploaded patch set 1 11/30/24, 10:45

  2. core-ci voted on patch set 1 V -1 11/30/24, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70377

  3. Christian Kuhn uploaded patch set 2 V -1 11/30/24, 11:40

  4. core-ci voted on patch set 2 V -1 11/30/24, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70378

  5. Christian Kuhn uploaded patch set 3 V -1 11/30/24, 11:47

  6. core-ci voted on patch set 3 V -1 11/30/24, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70379

  7. Christian Kuhn uploaded patch set 4 V -1 11/30/24, 12:43

  8. core-ci voted on patch set 4 V -1 11/30/24, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70382

  9. Christian Kuhn uploaded patch set 5 V -1 11/30/24, 14:43

  10. core-ci voted on patch set 5 V -1 11/30/24, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70383

  11. Christian Kuhn uploaded patch set 6 V -1 11/30/24, 15:14

  12. core-ci voted on patch set 6 V -1 11/30/24, 15:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70386

  13. Christian Kuhn uploaded patch set 7 V -1 11/30/24, 15:24

  14. core-ci voted on patch set 7 V -1 11/30/24, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70387

  15. Christian Kuhn uploaded patch set 8 V -1 11/30/24, 15:38

  16. core-ci voted on patch set 8 V +1 11/30/24, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70389

  17. Christian Kuhn uploaded patch set 9 V +1 11/30/24, 16:01

  18. Christian Kuhn updated the commit message in patch set 10 11/30/24, 16:03

  19. Stefan Bürk voted on patch set 10 CR +1 V +1 11/30/24, 16:08

  20. core-ci voted on patch set 9 V +1 11/30/24, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70391

  21. core-ci voted on patch set 10 V +1 11/30/24, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70392

  22. Anja Leichsenring voted on patch set 10 CR +1 V +1 11/30/24, 16:13

  23. Christian Kuhn voted on patch set 10 CR +2 V +2 11/30/24, 16:17

  24. Christian Kuhn merged patch set 11 11/30/24, 16:17