Review main Merged

87291[TASK] Avoid SingletonInterface in HashService

Christian Kuhn CR +2 V +2 Easy +1 −4 updated 11/30/24, 15:12

Commit message

There is no point in marking this stateless
service a singleton. DI will do this anyway
and it doesn't harm if created too often since
it (currently) has no depedencies.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Christian Kuhn uploaded patch set 1 11/30/24, 14:47

  2. core-ci voted on patch set 1 V +1 11/30/24, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70384

  3. Christian Kuhn uploaded patch set 2 V +1 11/30/24, 14:55

  4. core-ci voted on patch set 2 V +1 11/30/24, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70385

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 11/30/24, 15:05

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 11/30/24, 15:09

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 11/30/24, 15:12

  8. Christian Kuhn merged patch set 3 11/30/24, 15:12