Review 13.4 Merged

87293[TASK] Raise typo3/testing-framework

Christian Kuhn CR +2 V +2 Hard +301 −487 updated 11/30/24, 16:17

Commit message

New TF does not raise assertions in tearDown() anymore [1]
which makes phpunit detect more unit tests that don't
assert something. Some affected tests are legit and receive
the #[DoesNotPerformAssertions] attribute. Some others
were actually broken and are fixed to for instance now
expect calls on mocks. Further minor cleanups along the
way.

> composer req --dev typo3/testing-framework:^9.1.0

[1] https://github.com/TYPO3/testing-framework/pull/660

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 68

  1. Christian Kuhn uploaded patch set 1 11/30/24, 15:44

  2. core-ci voted on patch set 1 V +1 11/30/24, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70390

  3. Christian Kuhn uploaded patch set 2 V +1 11/30/24, 16:03

  4. Stefan Bürk voted on patch set 2 CR +1 V +1 11/30/24, 16:08

  5. core-ci voted on patch set 2 V +1 11/30/24, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70393

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 11/30/24, 16:13

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 11/30/24, 16:17

  8. Christian Kuhn merged patch set 3 11/30/24, 16:17