Review main Merged

87294[BUGFIX] Remove inconvenient nullable checkbox from datetime elements

Benjamin Franzke CR +2 V +2 Easy +1 −14 updated 12/10/24, 08:26

Commit message

The "Set value" checkbox is removed in order to increase user
experience, as a (nullable) datetime can handle the difference between
having a date set (concrete date value) and having no date
(input field is empty) itself.
An additional checkbox that disables the input field is superfluous,
confusing for editors and the checkbox-barrier actually prevented fast
user interaction, as two clicks were needed to start selecting a date.

Since #105666 an empty datepicker input is properly converted to
NULL by DataHandler for all dbType fields, which renders the
null-checkbox technically useless and allows this change to be
performed now.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 913

  1. Benjamin Franzke uploaded patch set 1 11/30/24, 16:20

  2. core-ci voted on patch set 1 V +1 11/30/24, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70394

  3. Benjamin Franzke uploaded patch set 2 V +1 12/06/24, 09:36

  4. core-ci voted on patch set 2 V +1 12/06/24, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70697

  5. Benjamin Franzke marked it ready for review 12/06/24, 09:45

  6. Benjamin Franzke updated the commit message in patch set 3 V +1 12/09/24, 10:18

  7. core-ci voted on patch set 3 V +1 12/09/24, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70799

  8. Benjamin Franzke updated the commit message in patch set 4 V +1 12/09/24, 10:56

  9. core-ci voted on patch set 4 V +1 12/09/24, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70801

  10. Andreas Kienast voted on patch set 4 CR +1 V +1 12/09/24, 14:19

  11. Benjamin Kott voted on patch set 4 CR +1 V +1 12/10/24, 08:14

  12. Benjamin Franzke voted on patch set 4 CR +2 V +2 12/10/24, 08:16

  13. Benjamin Franzke merged patch set 5 12/10/24, 08:26