Review main Merged Breaking

87297[!!!][TASK] Stateless FileNameValidator

Christian Kuhn CR +2 V +2 Normal +73 −41 updated 12/01/24, 12:50

Commit message

There is very little reason to instantiate
ext:core FileNameValidator with a custom
regex. The core does not have a single place
that uses this. The 'manual' constructor can
be removed without much trouble, making the
service stateless and easily injectable.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 69

  1. Christian Kuhn uploaded patch set 1 12/01/24, 01:26

  2. core-ci voted on patch set 1 V -1 12/01/24, 01:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70400

  3. Christian Kuhn uploaded patch set 2 V -1 12/01/24, 01:41

  4. core-ci voted on patch set 2 V +1 12/01/24, 01:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70401

  5. Christian Kuhn uploaded patch set 3 V +1 12/01/24, 02:10

  6. core-ci voted on patch set 3 V +1 12/01/24, 02:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70403

  7. Anja Leichsenring voted on patch set 3 CR +1 V +1 12/01/24, 07:06

  8. Stefan Bürk voted on patch set 3 CR +2 V +2 12/01/24, 12:50

  9. Stefan Bürk merged patch set 4 12/01/24, 12:50