Review main Merged

87300[TASK] Localize title for link browser

Sybille Peters CR +2 V +2 Easy +6 −1 updated 12/03/24, 13:21

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1316

  1. Sybille Peters uploaded patch set 1 12/01/24, 10:26

  2. core-ci voted on patch set 1 V +1 12/01/24, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70418

  3. Christian Kuhn commented on patch set 1 12/02/24, 20:19

    AbstractLinkBrowserController.php:195

    fallback is not needed i'd say.
  4. Sybille Peters uploaded patch set 2 V +1 12/02/24, 21:13

  5. Sybille Peters commented on patch set 2 12/02/24, 21:14

    AbstractLinkBrowserController.php:195 Reply

    Done
  6. core-ci voted on patch set 2 V +1 12/02/24, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70479

  7. Christian Kuhn voted on patch set 2 CR +1 V +1 12/02/24, 23:07

  8. Garvin Hicking commented on patch set 2 12/03/24, 06:00

    Backport 13.4?
  9. Anja Leichsenring voted on patch set 2 CR +1 V +1 12/03/24, 10:14

  10. Christian Kuhn commented on patch set 2 12/03/24, 11:45

    Reply

    your decision. i could live with both.
  11. Garvin Hicking updated the commit message in patch set 3 CR +1 V +1 12/03/24, 12:55

  12. Christian Kuhn commented on patch set 3 CR +1 V +1 12/03/24, 12:56

    Reply

    Done
  13. Anja Leichsenring voted on patch set 3 CR +1 V +1 12/03/24, 12:57

  14. core-ci voted on patch set 3 V +1 12/03/24, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70534

  15. Garvin Hicking commented on patch set 3 CR +2 V +2 12/03/24, 13:21

    Checked back with Georg; since the label is "fresh" and identical for all existing languages, this shouldn't be a problem.
  16. Garvin Hicking merged patch set 4 12/03/24, 13:21