Review main Merged

87302[TASK] More DI in Mail\TransportFactory

Christian Kuhn CR +2 V +2 Normal +54 −67 updated 12/02/24, 12:11

Commit message

TransportFactory can be turned into a readonly
stateless service quite easily. We get rid of
another LoggerAwareInterface and SingletonInterface
usage by this. This low level service is configured
in ext:core ServiceProvider which receives adaptions.
Minor cosmetical changes and test adaptions along
the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 812

  1. Christian Kuhn uploaded patch set 1 12/01/24, 23:16

  2. core-ci voted on patch set 1 V -1 12/01/24, 23:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70424

  3. Christian Kuhn uploaded patch set 2 V -1 12/01/24, 23:42

  4. core-ci voted on patch set 2 V -1 12/01/24, 23:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70425

  5. Christian Kuhn uploaded patch set 3 V -1 12/01/24, 23:58

  6. core-ci voted on patch set 3 V +1 12/02/24, 00:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70426

  7. Christian Kuhn updated the commit message in patch set 4 V +1 12/02/24, 10:20

  8. core-ci voted on patch set 4 V +1 12/02/24, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70445

  9. Anja Leichsenring voted on patch set 4 CR +1 V +1 12/02/24, 11:25

  10. Stefan Bürk voted on patch set 4 CR +1 V +1 12/02/24, 11:44

  11. Christian Kuhn voted on patch set 4 CR +2 V +2 12/02/24, 12:11

  12. Christian Kuhn merged patch set 5 12/02/24, 12:11