Review 12.4 Merged

87306[TASK] Activate PHP 8.4 functional tests

Christian Kuhn CR +2 V +2 Normal +92 −78 updated 12/03/24, 11:46

Commit message

Similar to #105740, we update some more dependencies
for PHP 8.4 compatibility. bacon/bacon-qr-code and
enshrined/svg-sanitize need (optional) major version
adaptions (0.x raises are considered "major" in semver).

Similar to v13 #104604, svg-sanitize related tests
need minor additional treatment to deal with
different PHP internals.

> composer u symfony/rate-limiter
> composer u symfony/var-exporter
> composer u symfony/messenger
> composer u symfony/doctrine-messenger
> composer u symfony/var-dumper
> composer req bacon/bacon-qr-code:"^2.0.7 || ^3.0.1"
> composer req bacon/bacon-qr-code:"^2.0.7 || ^3.0.1" -d typo3/sysext/core --no-update
> composer req enshrined/svg-sanitize:"^0.18.0 || ^0.20.0"
> composer req enshrined/svg-sanitize:"^0.18.0 || ^0.20.0" -d typo3/sysext/core --no-update

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 9

Review log 1018

  1. Christian Kuhn uploaded patch set 1 12/02/24, 14:04

  2. core-ci voted on patch set 1 V -1 12/02/24, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70460

  3. Christian Kuhn uploaded patch set 2 V -1 12/02/24, 14:22

  4. core-ci voted on patch set 2 V -1 12/02/24, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70464

  5. Christian Kuhn uploaded patch set 3 V -1 12/02/24, 18:08

  6. core-ci voted on patch set 3 V -1 12/02/24, 18:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70478

  7. Christian Kuhn uploaded patch set 4 V -1 12/02/24, 22:35

  8. core-ci voted on patch set 4 V +1 12/02/24, 22:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70480

  9. Christian Kuhn uploaded patch set 5 V +1 12/02/24, 22:57

  10. core-ci voted on patch set 4 V +1 12/02/24, 22:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70481

  11. Christian Kuhn updated the commit message in patch set 6 12/02/24, 22:59

  12. core-ci voted on patch set 5 V +1 12/02/24, 23:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70482

  13. core-ci voted on patch set 6 V +1 12/02/24, 23:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70483

  14. core-ci commented on patch set 6 12/02/24, 23:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70484

  15. Stefan Bürk voted on patch set 6 CR +1 V +1 12/03/24, 07:31

  16. Anja Leichsenring voted on patch set 6 CR +1 V +1 12/03/24, 10:14

  17. Christian Kuhn voted on patch set 6 CR +2 V +2 12/03/24, 11:46

  18. Christian Kuhn merged patch set 7 12/03/24, 11:46