Review main Merged

87307[BUGFIX] Add MM tablename and fieldnames fields with group/allowed

Christian Kuhn CR +2 V +2 Normal +193 −4 updated 12/02/24, 18:37

Commit message

Having a TCA type=group with allowed being set to multiple
tables and without configured "can be edited from foreign
side" option "MM_oppositeUsage" being set, is a valid TCA
MM configuration. This needs fields "tablename" and "fieldnames"
in the MM table, but DefaultTcaSchema currently ignores this
combination.

The patch takes care of this and adds a simple styleguide
example.

Note: MM TCA configuration is still far too complex and the
amount of options and combination permutations is opaque and
still not fully documented nor functional tested. We should
further reduce this complexity and add more solid testing
in this area.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1214

  1. Christian Kuhn uploaded patch set 1 12/02/24, 15:29

  2. core-ci voted on patch set 1 V -1 12/02/24, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70470

  3. Christian Kuhn uploaded patch set 2 V -1 12/02/24, 17:25

  4. core-ci voted on patch set 2 V +1 12/02/24, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70475

  5. Stefan Bürk voted on patch set 2 CR +1 12/02/24, 17:57

  6. Benni Mack commented on patch set 2 12/02/24, 18:01

    DefaultTcaSchema.php:1144

    I suggest ($tcaColumn['config']['type'] ?? '')
  7. Christian Kuhn commented on patch set 2 12/02/24, 18:09

    DefaultTcaSchema.php:1144 Reply

    Acknowledged
  8. Christian Kuhn commented on patch set 2 12/02/24, 18:11

    DefaultTcaSchema.php:1144 Reply

    this is tested above early already and triggers a loop continue: !is_string($tcaColumn['config']['type'] ?? false) -> continue.
  9. Anja Leichsenring commented on patch set 2 12/02/24, 18:14

    DefaultTcaSchema.php:1144 Reply

    that is taken care of in line 1051 (start of the method)
  10. Benni Mack commented on patch set 2 CR +1 V +1 12/02/24, 18:15

    DefaultTcaSchema.php:1144 Reply

    Acknowledged
  11. Stefan Bürk voted on patch set 2 V +1 12/02/24, 18:16

  12. Anja Leichsenring voted on patch set 2 CR +1 V +1 12/02/24, 18:27

  13. Christian Kuhn voted on patch set 2 CR +2 V +2 12/02/24, 18:37

  14. Christian Kuhn merged patch set 3 12/02/24, 18:37