87308[TASK] Offload charset table generation
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Christian Kuhn +1
- Oliver Hader +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 17
- Build/gitlab-ci/nightly/integrity.yml+1 −0
- Build/gitlab-ci/pre-merge/integrity.yml+1 −0
- Build/Scripts/runTests.sh+7 −1
- Build/Scripts/updateCharsetTables.phpnew+247 −0
- Build/Sources/Charsets/translit.txtrenamed+0 −0
- Build/Sources/Charsets/unicode-data.txtrenamed+0 −0
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+19 −247
- typo3/sysext/core/Classes/Charset/CharsetProvider.php9new+2516 −0
- typo3/sysext/core/Classes/ServiceProvider.php+9 −1
- typo3/sysext/core/Tests/Unit/Charset/CharsetConverterTest.php+3 −2
- typo3/sysext/core/Tests/Unit/DataHandling/SlugHelperTest.php+10 −9
- typo3/sysext/core/Tests/Unit/Slug/SlugNormalizerTest.php+2 −1
- typo3/sysext/form/Tests/Functional/Controller/FormManagerControllerTest.php+4 −4
- typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php+89 −0
- typo3/sysext/frontend/Tests/Unit/Imaging/GifBuilderTest.phpdeleted+0 −121
- typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php+0 −5
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+0 −1
Review log 2332
Show 57 earlier messages
-
Andreas Kienast uploaded patch set 1 12/02/24, 16:54
-
Andreas Kienast uploaded patch set 2 12/02/24, 16:54
-
Andreas Kienast commented on patch set 2 12/02/24, 16:59
@lolli@schwarzbu.ch since you recently worked on the CharsetConverter, can I please have your opinion on this? -
core-ci voted on patch set 1 V -1 12/02/24, 17:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70473
-
core-ci voted on patch set 2 V -1 12/02/24, 17:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70474
-
Christian Kuhn commented on patch set 2 12/02/24, 17:31
yep. i had a similar thing in mind 😊 i would suggest to create an (internal) DO class, similar to what we do with countries. this would be auto-loadable and we don't need resources stuff and manual require. -
Andreas Kienast uploaded patch set 3
V -112/03/24, 07:28
-
core-ci voted on patch set 3 V -1 12/03/24, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70503
-
Andreas Kienast uploaded patch set 4
V -102/04/25, 14:04 -
core-ci voted on patch set 4 V -1 02/04/25, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73497
-
Andreas Kienast uploaded patch set 5
V -102/04/25, 14:34 -
Andreas Kienast uploaded patch set 6 02/04/25, 14:34
-
core-ci voted on patch set 6 V -1 02/04/25, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73503
-
Andreas Kienast uploaded patch set 7
V -102/04/25, 14:57 -
Andreas Kienast updated the commit message in patch set 8 02/04/25, 14:57
-
core-ci voted on patch set 8 V -1 02/04/25, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73508
-
Andreas Kienast uploaded patch set 9
V -102/04/25, 15:40 -
core-ci voted on patch set 9 V +1 02/04/25, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73511
-
Oliver Hader commented on patch set 9 02/06/25, 07:54
I guess the GifBuilder changes are not related to CharsetConverter? Are they? -
Christian Kuhn commented on patch set 9 02/06/25, 08:39
i really like this. one thing: we could/should have a CI run in 'integration' that calls the script to verify nothing changes. this prevents that someone fiddles in the data class manually.CharsetProvider.php:26do we really need the alias? this is mainly an internal service used once/very seldomly?CharsetProvider.php:27not needed in this case since the class has no further dependencies anyways.CharsetProvider.php:28final readonly would be great in this case.CharsetProvider.php:35lets make this a constant. -
Andreas Kienast commented on patch set 9 02/06/25, 08:44
Reply
Ack.Reply
Yesn't. The changes in the GifBuilderTest became necessary by introducing DI to CharsetConverter.CharsetProvider.php:26ReplyHonestly, I bluntly copied this from the CountryProvider class.CharsetProvider.php:27ReplyAcknowledgedCharsetProvider.php:28ReplyAcknowledgedCharsetProvider.php:35ReplyAcknowledged -
Andreas Kienast uploaded patch set 10
V +102/06/25, 08:53 -
Christian Kuhn commented on patch set 10 02/06/25, 08:57
CharsetProvider.php:26ReplyDone -
Christian Kuhn commented on patch set 10 CR -1 02/06/25, 08:57
on it. -
core-ci voted on patch set 10 V +1 02/06/25, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73635
-
Christian Kuhn uploaded patch set 11
CR -1V +102/06/25, 09:42 -
core-ci voted on patch set 11 V +1 02/06/25, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73643
-
Christian Kuhn commented on patch set 11 CR +1 V +1 02/06/25, 09:52
played around with this and tuned details. -
Oliver Hader voted on patch set 11 CR +1 02/06/25, 10:03
-
Stefan Bürk voted on patch set 11 CR +1 V +1 02/06/25, 11:46
-
Andreas Kienast voted on patch set 11 CR +2 V +2 02/06/25, 12:35
-
Andreas Kienast merged patch set 12 02/06/25, 12:35