Review 12.4 Merged

87310[BUGFIX] Add MM tablename and fieldnames fields with group/allowed

Christian Kuhn CR +2 V +2 Normal +177 −3 updated 12/02/24, 18:38

Commit message

Having a TCA type=group with allowed being set to multiple
tables and without configured "can be edited from foreign
side" option "MM_oppositeUsage" being set, is a valid TCA
MM configuration. This needs fields "tablename" and "fieldnames"
in the MM table, but DefaultTcaSchema currently ignores this
combination.

The patch takes care of this.

Note: MM TCA configuration is still far too complex and the
amount of options and combination permutations is opaque and
still not fully documented nor functional tested. We should
further reduce this complexity and add more solid testing
in this area.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Christian Kuhn uploaded patch set 1 12/02/24, 17:43

  2. core-ci voted on patch set 1 V +1 12/02/24, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70477

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 12/02/24, 18:16

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 12/02/24, 18:38

  5. Christian Kuhn merged patch set 2 12/02/24, 18:38