87311[TASK] Clean up extbase DataMapFactory
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMap.php+1 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php3+25 −76
- typo3/sysext/extbase/Configuration/Services.yaml+0 −4
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapFactoryTest.php+11 −13
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+0 −18
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+4 −8
Review log 911
-
Christian Kuhn uploaded patch set 1 12/03/24, 01:04
-
core-ci voted on patch set 1 V +1 12/03/24, 01:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70486
-
Christian Kuhn updated the commit message in patch set 2
V +112/03/24, 01:26 -
core-ci voted on patch set 2 V +1 12/03/24, 01:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70487
-
Stefan Bürk voted on patch set 2 CR +1 V +1 12/03/24, 07:35
-
Andreas Kienast commented on patch set 2 12/03/24, 08:53
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 12/03/24, 10:13
-
Christian Kuhn commented on patch set 2 12/03/24, 11:52
DataMapFactory.php:70ReplyWell, maybe: This is relatively complex on the CF side to implement and get right (to for instance configure the sub caches), i remember i fiddled in this area quite a while ago, and i wouldn't be surprised if there is some extension that implements something. OTOH, putting this logic into the application that needs two-level caches is quite simple as you can see in the code here. and we don't have *that* many places that need something like that, the only place that comes to my mind currently is RootlineUtility, and that one has the chance to get rid of it. Thus: multi-level-cache-api is a rather seldom thing, single consumers can quite easily do on their own, and they're not trivial to get right as general API. I personally decided to not put time into this. -
Christian Kuhn commented on patch set 2 12/03/24, 11:56
DataMapFactory.php:70ReplyDone -
Christian Kuhn voted on patch set 2 CR +2 V +2 12/03/24, 11:56
-
Christian Kuhn merged patch set 3 12/03/24, 11:56
DataMapFactory.php:70