Review main Merged

87311[TASK] Clean up extbase DataMapFactory

Christian Kuhn CR +2 V +2 Normal +41 −119 updated 12/03/24, 11:56

Commit message

This is now a stateless service.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 911

  1. Christian Kuhn uploaded patch set 1 12/03/24, 01:04

  2. core-ci voted on patch set 1 V +1 12/03/24, 01:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70486

  3. Christian Kuhn updated the commit message in patch set 2 V +1 12/03/24, 01:26

  4. core-ci voted on patch set 2 V +1 12/03/24, 01:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70487

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 12/03/24, 07:35

  6. Andreas Kienast commented on patch set 2 12/03/24, 08:53

    DataMapFactory.php:70

    Perhaps it makes sense at some point to introduce cache chains in Caching Framework. Symfony allows to do something similar: https://symfony.com/doc/current/components/cache/adapters/chain_adapter.html
  7. Anja Leichsenring voted on patch set 2 CR +1 V +1 12/03/24, 10:13

  8. Christian Kuhn commented on patch set 2 12/03/24, 11:52

    DataMapFactory.php:70 Reply

    Well, maybe: This is relatively complex on the CF side to implement and get right (to for instance configure the sub caches), i remember i fiddled in this area quite a while ago, and i wouldn't be surprised if there is some extension that implements something. OTOH, putting this logic into the application that needs two-level caches is quite simple as you can see in the code here. and we don't have *that* many places that need something like that, the only place that comes to my mind currently is RootlineUtility, and that one has the chance to get rid of it. Thus: multi-level-cache-api is a rather seldom thing, single consumers can quite easily do on their own, and they're not trivial to get right as general API. I personally decided to not put time into this.
  9. Christian Kuhn commented on patch set 2 12/03/24, 11:56

    DataMapFactory.php:70 Reply

    Done
  10. Christian Kuhn voted on patch set 2 CR +2 V +2 12/03/24, 11:56

  11. Christian Kuhn merged patch set 3 12/03/24, 11:56