Review main Merged

87333[TASK] Add styleguide field generator for group with MM

Anja Leichsenring CR +2 V +2 Normal +77 −1 updated 12/03/24, 11:52

Commit message

TCA field type group with a MM table definition was introduced
with #102725, but received no field content generator. This not
only leaves the field empty, but also causes errors during
styleguide demo data generation, because the general group field
generator is picked up, that generates incompatible data. So now
a compatible generator is created and registered for this particular
TCA field configuration.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 710

  1. Anja Leichsenring uploaded patch set 1 12/03/24, 10:03

  2. core-ci voted on patch set 1 V +1 12/03/24, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70508

  3. core-ci commented on patch set 1 12/03/24, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70511

  4. Anja Leichsenring updated the commit message in patch set 2 V +1 12/03/24, 10:57

  5. core-ci voted on patch set 2 V +1 12/03/24, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70515

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 12/03/24, 11:45

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 12/03/24, 11:49

  8. Anja Leichsenring voted on patch set 2 CR +2 V +2 12/03/24, 11:52

  9. Anja Leichsenring merged patch set 3 12/03/24, 11:52

  10. Anja Leichsenring voted on patch set 2 CR +2 V +2 12/03/24, 11:52