Review main Merged

87334[TASK] Replace legacy css declarations

Benjamin Kott CR +2 V +2 Normal +48 −125 updated 12/11/24, 14:25

Commit message

- Drop unused input-size mixin
- Drop obsolete .modal-backdrop adjustments
- Move .hidden and .hide css classes to utility
- Move .page-header to install context
- Drop unnessesary inline wrapper and declarations
  for inline records in form-engine

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1520

  1. Benjamin Kott uploaded patch set 1 12/03/24, 10:15

  2. core-ci voted on patch set 1 V +1 12/03/24, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70509

  3. Benjamin Kott uploaded patch set 2 V +1 12/03/24, 12:32

  4. core-ci voted on patch set 2 V -1 12/03/24, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70528

  5. Benjamin Kott uploaded patch set 3 V -1 12/03/24, 12:43

  6. core-ci voted on patch set 3 V +1 12/03/24, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70529

  7. Benjamin Kott uploaded patch set 4 V +1 12/03/24, 12:53

  8. Benjamin Kott rebased onto patch set 5 12/03/24, 13:25

  9. core-ci voted on patch set 5 V +1 12/03/24, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70537

  10. Andreas Kienast voted on patch set 5 CR +1 V +1 12/03/24, 13:46

  11. Benjamin Franzke commented on patch set 5 12/04/24, 08:37

    Is an actual *bug* fixed, or is it just cleanups (commit msg reads like a TASK)
  12. Benjamin Franzke updated the commit message in patch set 6 CR +1 V +1 12/04/24, 09:12

  13. Benjamin Franzke commented on patch set 6 CR +1 12/04/24, 09:13

    Reply

    Done
  14. Benjamin Franzke voted on patch set 6 V +1 12/04/24, 09:16

  15. core-ci voted on patch set 6 V +1 12/04/24, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70572

  16. Andreas Kienast voted on patch set 6 CR +2 V +2 12/04/24, 15:54

  17. Andreas Kienast merged patch set 7 12/04/24, 16:03

  18. Andreas Kienast commented on patch set 7 12/11/24, 10:45

    Post -1: this breaks IRRE with minitems=1, where the "Create new" button is initially hidden and should become visible once the item is removed.
  19. Benjamin Kott commented on patch set 7 12/11/24, 14:24

  20. Benjamin Kott commented on patch set 7 12/11/24, 14:25

    Reply

    Acknowledged