Review main Merged

87347[TASK] Turn extbase DataMap into a readonly DO

Christian Kuhn CR +2 V +2 Hard +207 −607 updated 12/04/24, 00:15

Commit message

Since DataMapFactory is the only class creating
DataMap instances, DataMap can be turned into a
readonly data object quite easily and without
being breaking:

* Public constructor property promotion
* Final readonly class
* DataMapFactory uses named arguments with this
  now immutable data object, which is mandatory
  for these type of classes according to [1]
* Removed setters
* Avoid getters in consumers and use properties
* Keep getters to not break anything, even though
  the class is marked @internal: The getters does
  not harm much.
* Proper PHP types

[1] https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/CodingGuidelines/CodingBestPractices/NamedArguments.html

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1118

  1. Christian Kuhn uploaded patch set 1 12/03/24, 16:58

  2. core-ci voted on patch set 1 V +1 12/03/24, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70544

  3. Christian Kuhn uploaded patch set 2 V +1 12/03/24, 18:03

  4. core-ci voted on patch set 2 V -1 12/03/24, 18:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70545

  5. Christian Kuhn uploaded patch set 3 V -1 12/03/24, 18:44

  6. Christian Kuhn uploaded patch set 4 12/03/24, 18:45

  7. core-ci voted on patch set 3 V +1 12/03/24, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70546

  8. Christian Kuhn uploaded patch set 5 12/03/24, 18:51

  9. core-ci voted on patch set 4 V -1 12/03/24, 18:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70547

  10. core-ci voted on patch set 5 V +1 12/03/24, 18:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70548

  11. Christian Kuhn uploaded patch set 6 V +1 12/03/24, 22:00

  12. core-ci voted on patch set 6 V +1 12/03/24, 22:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70550

  13. Christian Kuhn uploaded patch set 7 V +1 12/03/24, 22:28

  14. core-ci voted on patch set 7 V +1 12/03/24, 22:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70551

  15. Stefan Bürk voted on patch set 7 CR +1 V +1 12/03/24, 22:52

  16. Garvin Hicking commented on patch set 7 CR +1 V +1 12/03/24, 23:03

    That came together quite well 👍
  17. Christian Kuhn voted on patch set 7 CR +2 V +2 12/04/24, 00:15

  18. Christian Kuhn merged patch set 8 12/04/24, 00:15