87350[BUGFIX] Include modal-trigger button value in submitted form data
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Oliver Hader +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Oliver Hader +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1013
-
Benjamin Franzke uploaded patch set 1 12/04/24, 10:04
-
Benjamin Franzke uploaded patch set 2 12/04/24, 10:08
-
Benjamin Franzke uploaded patch set 3 12/04/24, 10:09
-
core-ci voted on patch set 3 V +1 12/04/24, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70578
-
Benjamin Franzke uploaded patch set 4
V +112/04/24, 10:36 -
core-ci voted on patch set 4 V +1 12/04/24, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70579
-
Benjamin Franzke updated the commit message in patch set 5
V +112/05/24, 09:05 -
core-ci voted on patch set 5 V +1 12/05/24, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70629
-
Andreas Kienast voted on patch set 5 CR +1 V +1 12/05/24, 10:06
-
Oliver Hader voted on patch set 5 CR +1 V +1 12/09/24, 14:29
-
Oliver Hader commented on patch set 5 12/09/24, 14:42
-
Benjamin Franzke commented on patch set 5 CR +2 V +2 12/09/24, 14:56
modal.ts:550Replyack I also think this is fine. I actually didn't mention this difference because we do not use modal-confirmation-buttons on form's with form validations, but yes, using `requestSubmit()` would be fine in this case and if this is ever used with form validations the user can click again and then requestSubmit will run again. Hope it's fine to mark this as resolved. Thanks for checking! -
Benjamin Franzke merged patch set 6 12/09/24, 14:56
modal.ts:550