87351[TASK] Provide more tests for DataMapFactory
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 7
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/RestrictedComment.phpnew+90 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Repository/RestrictedCommentRepository.phpnew+32 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_restrictedcomment.php2new+48 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xlf+18 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/Fixtures/DataMapperCustomRestrictionFields.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapFactoryTest.php+20 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php2+92 −33
Review log 1620
-
Garvin Hicking uploaded patch set 1 12/04/24, 11:07
-
Garvin Hicking uploaded patch set 2 12/04/24, 11:10
-
core-ci voted on patch set 1 V -1 12/04/24, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70580
-
core-ci voted on patch set 2 V -1 12/04/24, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70581
-
Garvin Hicking uploaded patch set 3
V -112/04/24, 11:20Happify Stan the man -
core-ci voted on patch set 3 V +1 12/04/24, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70582
-
Benni Mack voted on patch set 3 CR +1 V +1 12/04/24, 11:37
-
Oli Bartsch voted on patch set 3 CR +1 V +1 12/04/24, 12:18
-
Oli Bartsch commented on patch set 3 12/04/24, 12:19
tx_blogexample_domain_model_restrictedcomment.php:35Do we really need to define the columns? Usually they should be generated automatically based on ctrl. -
Christian Kuhn commented on patch set 3 12/04/24, 15:39
DataMapperTest.php:621asserting a .csv fixture would probably be more convenient here and would omit the need for the querybuilder stuff. -
Christian Kuhn commented on patch set 3 CR -1 12/04/24, 15:55
on it. -
Christian Kuhn commented on patch set 3 12/04/24, 16:04
tx_blogexample_domain_model_restrictedcomment.php:35ReplyDone -
Christian Kuhn commented on patch set 3 12/04/24, 16:22
DataMapperTest.php:621ReplyDone -
Christian Kuhn uploaded patch set 4
CR +1V +112/04/24, 16:28 -
core-ci voted on patch set 4 V +1 12/04/24, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70599
-
Christian Kuhn voted on patch set 4 CR +1 V +1 12/04/24, 16:34
-
Benni Mack voted on patch set 4 CR +1 V +1 12/04/24, 16:35
-
Oli Bartsch voted on patch set 4 CR +1 V +1 12/04/24, 16:38
-
Garvin Hicking commented on patch set 4 CR +2 V +2 12/04/24, 17:26
Thanks all for improving this! -
Garvin Hicking merged patch set 5 12/04/24, 17:26