Review main Merged

87352[BUGFIX] Make grideditor context aware

Benjamin Kott CR +2 V +2 Normal +50 −37 updated 01/14/25, 11:24

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Benjamin Kott uploaded patch set 1 12/04/24, 11:33

  2. core-ci voted on patch set 1 V +1 12/04/24, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70584

  3. Andreas Kienast commented on patch set 1 CR -1 12/05/24, 11:19

    _grideditor.scss:13

    `--grideditor-action-color` is not used at all, probably missing in `.grideditor-action`?
  4. Benjamin Kott uploaded patch set 2 CR -1 V +1 12/05/24, 11:59

  5. Benjamin Kott commented on patch set 2 12/05/24, 12:03

    _grideditor.scss:13 Reply

    good catch, missed it in the base
  6. Benjamin Kott commented on patch set 2 12/05/24, 12:03

    _grideditor.scss:13 Reply

    Done
  7. core-ci voted on patch set 2 V +1 12/05/24, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70648

  8. Andreas Kienast voted on patch set 2 CR +1 V +1 12/05/24, 12:17

  9. Benni Mack voted on patch set 2 CR +1 V +1 12/13/24, 15:17

  10. Benjamin Kott voted on patch set 2 CR +2 V +2 01/14/25, 10:55

  11. Benjamin Kott merged patch set 3 01/14/25, 11:24