Review main Merged

87358[BUGFIX] Apply `options.showHistory` default in EditDocumentController

Benjamin Kott CR +2 V +2 Easy +2 −1 updated 12/05/24, 09:17

Commit message

The User TSConfig "showHistory" feature is considered to be active by
default in DatabaseRecordList and ContextMenu providers.
Align the EditDocumentController to use the same algorithm for
evaluating the `options.showHistory` setting.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Benjamin Kott uploaded patch set 1 12/04/24, 13:22

  2. core-ci voted on patch set 1 V +1 12/04/24, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70591

  3. Andreas Kienast commented on patch set 1 CR +1 V +1 12/05/24, 06:58

    For people like me wondering where the button is hidden: it's in the secondary toolbar group (righthand side in ltr mode).
  4. Benjamin Franzke uploaded patch set 2 CR +1 V +1 12/05/24, 08:44

  5. core-ci voted on patch set 2 V +1 12/05/24, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70627

  6. Andreas Kienast voted on patch set 2 CR +2 V +2 12/05/24, 09:06

  7. Andreas Kienast merged patch set 3 12/05/24, 09:17