Review 13.4 Merged

87373[BUGFIX] Optimize prerequisite query in sys_log serialization updater

Patrick Schriner CR +2 V +2 Easy +4 −2 updated 12/05/24, 12:23

Commit message

Counts with a restriction are very expensive if there are many records.
Limit the query to once occurence, as that's sufficient for the task of
checking if any rows need to be updated and faster than a full count.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Patrick Schriner commented on patch set 1 12/05/24, 11:25

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/05/24, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70641

  3. Oliver Klee commented on patch set 1 12/05/24, 11:40

    Is `main` affected as well?
  4. Garvin Hicking commented on patch set 1 CR +1 V +1 12/05/24, 11:53

    Reply

    No the wizard is removed in main.
  5. Benjamin Franzke updated the commit message in patch set 2 CR +1 V +1 12/05/24, 11:57

  6. Benjamin Franzke commented on patch set 2 CR +1 12/05/24, 11:59

    Reply

    No, it has been introduced with v12, that means it is removed in main
  7. Benjamin Franzke voted on patch set 2 V +1 12/05/24, 12:01

  8. core-ci voted on patch set 2 V +1 12/05/24, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70647

  9. Andreas Kienast voted on patch set 2 CR +2 V +2 12/05/24, 12:16

  10. Andreas Kienast merged patch set 3 12/05/24, 12:23