Review main Merged

87380[TASK] Turn extbase ColumnMap into a readonly DO

Christian Kuhn CR +2 V +2 Expert +556 −699 updated 12/09/24, 12:22

Commit message

Similar to extbase DataMap with #105757, ColumnMap
is turned into a readonly data object using public
property promotion. This is not breaking since
ColumnMap is `@internal` and only created by
ColumnMapFactory, which is simplified along the way.
The get'ers are unused, but kept since they don't
harm much.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 15

Review log 1321

  1. Christian Kuhn uploaded patch set 1 12/05/24, 16:09

  2. Christian Kuhn commented on patch set 1 12/05/24, 16:10

    first blood :) let's see if we can turn this into a readonly DO like DataMap as well.
  3. core-ci voted on patch set 1 V -1 12/05/24, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70665

  4. Christian Kuhn uploaded patch set 2 V -1 12/07/24, 10:59

  5. core-ci voted on patch set 2 V -1 12/07/24, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70742

  6. Christian Kuhn uploaded patch set 3 V -1 12/08/24, 08:14

  7. core-ci voted on patch set 3 V -1 12/08/24, 08:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70768

  8. Christian Kuhn uploaded patch set 4 V -1 12/08/24, 08:28

  9. core-ci voted on patch set 4 V -1 12/08/24, 08:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70769

  10. Christian Kuhn uploaded patch set 5 V -1 12/08/24, 08:44

  11. core-ci voted on patch set 5 V -1 12/08/24, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70770

  12. Christian Kuhn uploaded patch set 6 V -1 12/08/24, 08:55

  13. core-ci voted on patch set 6 V +1 12/08/24, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70771

  14. Christian Kuhn uploaded patch set 7 V +1 12/08/24, 09:32

  15. core-ci voted on patch set 7 V +1 12/08/24, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70772

  16. Christian Kuhn uploaded patch set 8 V +1 12/09/24, 10:50

  17. core-ci voted on patch set 8 V +1 12/09/24, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70800

  18. Anja Leichsenring voted on patch set 8 CR +1 V +1 12/09/24, 12:08

  19. Stefan Bürk voted on patch set 8 CR +1 V +1 12/09/24, 12:17

  20. Christian Kuhn voted on patch set 8 CR +2 V +2 12/09/24, 12:22

  21. Christian Kuhn merged patch set 9 12/09/24, 12:22