Review 13.4 Merged

87381[BUGFIX] Prevent plugin subtype labels override CType labels

Nikita Hovratov CR +2 V +2 Normal +83 −1 updated 12/17/24, 15:37

Commit message

The plugin subtype labels would override the CType labels if a group
with the same identifier exists. This is now avoided by doing a more
controlled merge of the arrays.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 910

  1. Nikita Hovratov uploaded patch set 1 12/05/24, 19:56

  2. core-ci voted on patch set 1 V +1 12/05/24, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70670

  3. Christian Kuhn commented on patch set 1 CR -1 12/09/24, 11:50

    the new test does not fail when i revert the subject change?
  4. Nikita Hovratov commented on patch set 1 12/09/24, 13:21

    Reply

    Naturally, as the test is testing a new method, which doesn't exist before. You can put the array_replace_recursive into the method to verify.
  5. Christian Kuhn commented on patch set 1 12/11/24, 18:24

    Reply

    Acknowledged.
  6. Christian Kuhn voted on patch set 1 CR 0 12/11/24, 18:24

  7. Christian Kuhn voted on patch set 1 CR +1 12/12/24, 11:43

  8. Christian Kuhn voted on patch set 1 V +1 12/17/24, 14:23

  9. Oli Bartsch voted on patch set 1 CR +2 V +2 12/17/24, 15:37

  10. Oli Bartsch merged patch set 2 12/17/24, 15:37