Review main Merged

87382[BUGFIX] Respect order of item groups in NewContentElementWizard

Nikita Hovratov CR +2 V +2 Hard +274 −7 updated 01/23/25, 11:48

Commit message

Since the change of registering wizard items groups with TCA in #102834
the order of groups can't be changed anymore in the wizard.

This is addressed now with a rather simple solution: When TCA groups are
added, the sorting is already ensured by EMU:addTcaSelectItemGroup. We
take this sorting and auto-add the positional information in
NewContentElementController by list-linking the groups by
"after:{theGroupBefore}". This way the sorting is well-defined.

How to deal with PageTs: Well, we can't have it both ways. As soon
as PageTs overrides at least one group order, this will overrule the
TCA sorting. Then, everything has to be defined via PageTs. This is
fine, as we strive to reduce usage of PageTs.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1928

Show 23 earlier messages
  1. Nikita Hovratov uploaded patch set 1 12/05/24, 21:54

  2. core-ci voted on patch set 1 V +1 12/05/24, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70671

  3. Nikita Hovratov updated the commit message in patch set 2 V +1 12/05/24, 22:06

  1. Nikita Hovratov uploaded patch set 3 12/05/24, 22:11

  2. core-ci voted on patch set 2 V +1 12/05/24, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70672

  3. core-ci voted on patch set 3 V +1 12/05/24, 22:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70673

  4. Nikita Hovratov uploaded patch set 4 V +1 12/05/24, 22:20

  5. core-ci voted on patch set 4 V +1 12/05/24, 22:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70674

  6. Nikita Hovratov uploaded patch set 5 V +1 12/05/24, 22:34

  7. core-ci voted on patch set 5 V +1 12/05/24, 22:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70675

  8. Anja Leichsenring voted on patch set 5 CR +1 V +1 12/06/24, 12:26

  9. Markus Klein commented on patch set 5 12/07/24, 18:27

    NewContentElementController.php:282

    maybe use $groupIdentifier like below

    NewContentElementController.php:354

    This shouts for a unit test to "proof" this
  10. Nikita Hovratov uploaded patch set 6 CR +1 V +1 12/09/24, 08:44

  11. Nikita Hovratov commented on patch set 6 12/09/24, 08:44

    NewContentElementController.php:282 Reply

    Done
  12. core-ci voted on patch set 6 V -1 12/09/24, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70796

  13. Nikita Hovratov uploaded patch set 7 V -1 12/09/24, 09:15

  14. Nikita Hovratov commented on patch set 7 12/09/24, 09:15

    NewContentElementController.php:354 Reply

    Done
  15. core-ci voted on patch set 7 V +1 12/09/24, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70797

  16. Nikita Hovratov rebased onto patch set 8 V +1 12/12/24, 13:49

  17. core-ci voted on patch set 8 V +1 12/12/24, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71031

  18. Nikita Hovratov rebased onto patch set 9 V +1 01/10/25, 13:27

  19. core-ci voted on patch set 9 V +1 01/10/25, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72212

  20. Benni Mack voted on patch set 9 CR +1 01/13/25, 16:24

  21. Georg Ringer voted on patch set 9 CR +1 V +1 01/13/25, 20:53

  22. Garvin Hicking voted on patch set 9 CR +2 V +2 01/23/25, 09:17

  23. Garvin Hicking commented on patch set 9 CR +1 V +1 01/23/25, 09:40

    Backport https://review.typo3.org/c/Packages/TYPO3.CMS/+/87861 needs work due to changes of loadAvailableWizards()
  24. Garvin Hicking voted on patch set 9 CR +2 V +2 01/23/25, 11:48

  25. Garvin Hicking merged patch set 10 01/23/25, 11:48