Review main Merged

87383[TASK] Update `typo3/testing-framework`

Stefan Bürk CR +2 V +2 Easy +6 −6 updated 12/06/24, 08:24

Commit message

Update `typo3/testing-framework` to ensure having latest
changes available and prepare for removing a temporary
solution added with #103297 and remove duplicated code
from codeception environment setup class which is now
provided with the new `typo3/testing-framework` releases
[1][2] containing [3][4][5].

Following updates are made depending on TYPO3 branch:

* main: update typo3/testing-framework:dev-main [5]
* 13.4: Require typo3/testing-framework:9.1.2 [3]
* 12.4: Require typo3/testing-framework:8.2.7 [4]

Used command(s):

> composer update typo3/testing-framework

Removing of temporary solution and duplicated code will
be handled with dedicated followup changes.

[1] https://github.com/TYPO3/testing-framework/releases/tag/9.1.2
[2] https://github.com/TYPO3/testing-framework/releases/tag/8.2.7
[3] https://github.com/TYPO3/testing-framework/pull/663
[4] https://github.com/TYPO3/testing-framework/pull/664
[5] https://github.com/TYPO3/testing-framework/commit/e9c3bc4df912a0fd5d1c69cc1cab0cca984b0207

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Stefan Bürk uploaded patch set 1 12/05/24, 22:51

  2. core-ci voted on patch set 1 V +1 12/05/24, 22:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70676

  3. Benni Mack voted on patch set 1 CR +1 V +1 12/06/24, 08:20

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 12/06/24, 08:23

    (only superficially tested)
  5. Stefan Bürk voted on patch set 1 CR +2 V +2 12/06/24, 08:24

  6. Andreas Kienast voted on patch set 1 CR +1 V +1 12/06/24, 08:24

  7. Stefan Bürk merged patch set 2 12/06/24, 08:24