Review 13.4 Merged

87384[TASK] Update `typo3/testing-framework`

Stefan Bürk CR +2 V +2 Easy +12 −12 updated 12/06/24, 08:24

Commit message

Update `typo3/testing-framework` to ensure having latest
changes available and prepare for removing a temporary
solution added with #103297 and remove duplicated code
from codeception environment setup class which is now
provided with the new `typo3/testing-framework` releases
[1][2] containing [3][4][5].

Following updates are made depending on TYPO3 branch:

* main: update typo3/testing-framework:dev-main [5]
* 13.4: Require typo3/testing-framework:9.1.2 [3]
* 12.4: Require typo3/testing-framework:8.2.7 [4]

Used command(s):

> sed -i 's/typo3\/testing-framework:^9.0.3/typo3\/testing-framework:^9.1.2/g' \
  Build/Scripts/setupAcceptanceComposer.sh
> composer require --no-update \
    -d Build/tests/packages/dataset_import \
    typo3/testing-framework:^9.1.2
> composer require --dev typo3/testing-framework:^9.1.2

Removing of temporary solution and duplicated code will
be handled with dedicated followup changes.

[1] https://github.com/TYPO3/testing-framework/releases/tag/9.1.2
[2] https://github.com/TYPO3/testing-framework/releases/tag/8.2.7
[3] https://github.com/TYPO3/testing-framework/pull/663
[4] https://github.com/TYPO3/testing-framework/pull/664
[5] https://github.com/TYPO3/testing-framework/commit/e9c3bc4df912a0fd5d1c69cc1cab0cca984b0207

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 45

  1. Stefan Bürk uploaded patch set 1 12/05/24, 23:00

  2. core-ci voted on patch set 1 V +1 12/05/24, 23:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70677

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 12/06/24, 08:23

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 12/06/24, 08:24

  5. Stefan Bürk merged patch set 2 12/06/24, 08:24