Review main Merged

87389[TASK] Replace static cache property with DI

Anja Leichsenring CR +2 V +2 Easy +13 −13 updated 12/09/24, 12:09

Commit message

The static runtime cache property of class UsernameViewHelper
can be replaced with an injected Cache Frontend property.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Sascha Nowak +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Sascha Nowak +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Anja Leichsenring uploaded patch set 1 12/06/24, 11:54

  2. core-ci voted on patch set 1 V +1 12/06/24, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70701

  3. Christian Kuhn commented on patch set 1 V -1 12/06/24, 12:35

    "be.viewhelper.username_1" is not a valid cache entry identifier.
  4. Anja Leichsenring uploaded patch set 2 V +1 12/06/24, 12:42

  5. core-ci voted on patch set 2 V +1 12/06/24, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70706

  6. Christian Kuhn uploaded patch set 3 V +1 12/09/24, 11:04

  7. Christian Kuhn voted on patch set 3 CR +1 V +1 12/09/24, 11:04

  8. core-ci voted on patch set 3 V +1 12/09/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70802

  9. Sascha Nowak voted on patch set 3 CR +1 V +1 12/09/24, 12:03

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 12/09/24, 12:09

  11. Christian Kuhn merged patch set 4 12/09/24, 12:09