87394[BUGFIX] Avoid trailing slash in HTML5 compliance mode
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormViewHelper.php+14 −1
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+9 −7
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FormViewHelperTest.php+12 −12
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+5 −4
- typo3/sysext/seo/Classes/Canonical/CanonicalGenerator.php+3 −1
- typo3/sysext/seo/Tests/Functional/Canonical/CanonicalGeneratorTest.php+9 −9
- typo3/sysext/seo/Tests/Functional/HrefLang/HrefLangGeneratorTest.php+31 −31
Review log 1014
-
Chris Müller uploaded patch set 1 12/08/24, 11:12
-
core-ci voted on patch set 1 V +1 12/08/24, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70775
-
Stefan Bürk commented on patch set 1 12/08/24, 11:52
Can we explain the background a little bit in the commit message ? Will not be clear for every one. And having some link(s) for readup about the `self-closing` tag slash thingy, which this change is about, should also be added. -
Benni Mack commented on patch set 1 CR -1 12/10/24, 16:22
This should only happen in HTML5-based projects. See TSFE: $docType = DocType::createFromConfigurationKey($typoScriptConfigArray['doctype']); $this->pageRenderer->setDocType($docType); to check for the doctype -
Benni Mack uploaded patch set 2
CR -1V +103/21/25, 19:09 -
core-ci voted on patch set 2 V -1 03/21/25, 19:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75971
-
Benni Mack uploaded patch set 3
V -103/21/25, 19:28 -
core-ci voted on patch set 3 V -1 03/21/25, 19:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75975
-
Benni Mack uploaded patch set 4
V -103/21/25, 19:57 -
core-ci voted on patch set 4 V +1 03/21/25, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75978
-
Benni Mack voted on patch set 4 CR +1 V +1 03/21/25, 20:08
-
Garvin Hicking commented on patch set 4 03/21/25, 20:13
Unresolved
how about not having an empty space before the closing angle bracket in html5 mode? Not required but it looks a bit odd woth it: `<input type="hdden" name="x" value="x" >` vs `<input type="hdden" name="x" value="x">` -
Georg Ringer voted on patch set 4 CR +2 V +2 03/21/25, 20:13
-
Georg Ringer merged patch set 5 03/21/25, 20:13