Review main Merged

87396[BUGFIX] Improve usability for selectTree

Sybille Peters CR +2 V +2 Easy +15 −3 updated 12/12/24, 08:53

Commit message

(1) Change input type to "search" in selectTree filter

Change input type to "search" in selectTree filter. This way, it is
possible to X out the text. This is more consistent with the other
fields like this, such as the page tree filter.

(2) Make language labels available

Some language labels were already been used (as title attributes
for the buttons and as placeholder text in the input field) but
the texts were not defined. The language labels are added to
locallang_alt_doc.xlf. The buttons now show a short description
on hover.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 2026

Show 1 earlier messages
  1. Sybille Peters uploaded patch set 1 12/08/24, 17:57

  1. core-ci voted on patch set 1 V +1 12/08/24, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70778

  2. Sybille Peters uploaded patch set 2 V +1 12/08/24, 18:49

  3. Sybille Peters commented on patch set 2 V -1 12/08/24, 18:50

    See commit msg: language labels are not displayed
  4. core-ci voted on patch set 2 V +1 12/08/24, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70779

  5. Sybille Peters uploaded patch set 3 V +1 12/09/24, 17:50

  6. core-ci voted on patch set 3 V +1 12/09/24, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70824

  7. Sybille Peters uploaded patch set 4 V +1 12/09/24, 17:59

  8. Sybille Peters updated the commit message in patch set 5 12/09/24, 18:01

  9. core-ci voted on patch set 4 V +1 12/09/24, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70825

  10. core-ci voted on patch set 5 V +1 12/09/24, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70826

  11. Simon Schaufelberger commented on patch set 5 12/10/24, 15:35

    I consider part 2 even a bugfix. What do you think?
  12. Sybille Peters commented on patch set 5 12/10/24, 16:49

    Reply

    Probably both could be considered bugfixes. I am not sure if the implications are and if it is relevant. AFAIK, it is only relevant if we want to backport, e.g. to 13.4. Then it should be a BUGFIX Better if someone else comments or decides.
  13. Benni Mack updated the commit message in patch set 6 V +1 12/11/24, 16:18

  14. Benni Mack commented on patch set 6 12/11/24, 16:18

    Reply

    Done
  15. core-ci voted on patch set 6 V +1 12/11/24, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70954

  16. Garvin Hicking voted on patch set 6 CR +1 V +1 12/11/24, 17:14

  17. Jasmina Ließmann voted on patch set 6 CR +1 12/11/24, 20:54

  18. Jasmina Ließmann commented on patch set 6 12/11/24, 21:24

    I tested in Firefox, Chrome and Edge on Windows. I can confirm that the close/x icon appears in Chrome and Edge with this patch. However, Firefox still doesn't show any icon.
  19. Jasmina Ließmann voted on patch set 6 V +1 12/11/24, 21:28

  20. Benni Mack voted on patch set 6 CR +1 V +1 12/11/24, 22:43

  21. Benni Mack commented on patch set 6 12/11/24, 22:44

    Reply

    Firefox doesn't show the icon. AFAIK that is correct as the icon is browser-specific and firefox does not show it.
  22. Sybille Peters commented on patch set 6 12/12/24, 08:04

    Reply

    I guess that would be the same for other input type="search" as well in the Backend, such as in the page tree? I checked, the filter in page tree also does not show the X in firefox.
  23. Jasmina Ließmann commented on patch set 6 12/12/24, 08:35

    Reply

    @sypets@gmx.de Yes. And @benni@typo3.org is right. Firefox does not support the x icon for input[type="search"] (see https://developer.mozilla.org/en-US/docs/Web/CSS/::-webkit-search-cancel-button). When testing, I fell into this trap again. The patch is not responsible for this and works fine so far. Sorry for the confusion.
  24. Jasmina Ließmann voted on patch set 6 CR +2 V +2 12/12/24, 08:36

  25. Jasmina Ließmann merged patch set 7 12/12/24, 08:53