Review 13.4 Merged

87404[BUGFIX] Include modal-trigger button value in submitted form data

Benjamin Franzke CR +2 V +2 Easy +13 −17 updated 12/09/24, 14:56

Commit message

An intercepted (via confirm modal) form submit button with a name and
value attribute is now included in the form-payload by requesting the
submit with the button as context instead of manually submitting the
form without trigger-button context.

This ensures that button values are actually submitted and can be used
to carry relevant payload. The site configuration overview is
adapted to make use of this by removing unnecessarily duplicated forms.

Codewise we now make use of the read-only `form` property of HTML
elements that are associated to a form (either implicitly via nesting
or explicit via `form=""` attribute) to avoid manual DOM lookups, see:
https://developer.mozilla.org/en-US/docs/Web/API/HTMLObjectElement/form

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 34

  1. Benjamin Franzke uploaded patch set 1 12/09/24, 14:24

  2. core-ci voted on patch set 1 V +1 12/09/24, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70817

  3. Benjamin Franzke commented on patch set 1 CR +2 V +2 12/09/24, 14:56

    This change is ready for review.
  4. Benjamin Franzke merged patch set 2 12/09/24, 14:56