Review main Merged

87405[TASK] Make FormEngine InlineStackProcessor stateless

Christian Kuhn CR +2 V +2 Hard +293 −437 updated 12/11/24, 08:54

Commit message

FormEngine related InlineStackProcessor is quite a
convoluted beast that never received true love, not
even during FormEngine rewrite in v7/v8.

As one key issue, the service is stateful since it
parks the given "inlineStructure" in a class property
that has to be "initialized" and is then used in all
read and manipulation methods.

Shared instances of this class are already injected at
some places within FormEngine, making its statefulness
even more unfortunate.

The patch puts an end to this by changing the methods to
always receive the current "inlineStructure" as argument,
removing the state property and declaring the class
readonly. Consumers are carefully adapted and instances
of this now stateless service are now always injected.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 1218

  1. Christian Kuhn uploaded patch set 1 12/09/24, 15:16

  2. core-ci voted on patch set 1 V +1 12/09/24, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70818

  3. Christian Kuhn uploaded patch set 2 V +1 12/09/24, 15:30

  4. Christian Kuhn uploaded patch set 3 12/09/24, 15:33

  5. core-ci voted on patch set 2 V +1 12/09/24, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70819

  6. core-ci voted on patch set 3 V +1 12/09/24, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70820

  7. Christian Kuhn uploaded patch set 4 V +1 12/10/24, 10:29

  8. core-ci voted on patch set 4 V +1 12/10/24, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70852

  9. Christian Kuhn uploaded patch set 5 V +1 12/10/24, 10:58

  10. core-ci voted on patch set 5 V +1 12/10/24, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70853

  11. Stefan Bürk voted on patch set 5 CR +1 12/10/24, 15:10

  12. Stefan Bürk voted on patch set 5 V +1 12/10/24, 15:52

  13. Christian Kuhn uploaded patch set 6 CR +1 V +1 12/11/24, 08:27

  14. Stefan Bürk voted on patch set 6 CR +1 V +1 12/11/24, 08:30

  15. core-ci voted on patch set 6 V +1 12/11/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70896

  16. Anja Leichsenring voted on patch set 6 CR +1 V +1 12/11/24, 08:43

  17. Christian Kuhn voted on patch set 6 CR +2 V +2 12/11/24, 08:53

  18. Christian Kuhn merged patch set 7 12/11/24, 08:54