Review main Merged

87421[BUGFIX] Ensure runtime cache is always using transient backend

Benjamin Franzke CR +2 V +2 Easy +13 −4 updated 12/11/24, 15:02

Commit message

Certain usages of the runtime cache require Closures to be stored.
VariableFrontend will try to serialize objects if the backend is not
a transient memory backend causing exceptions to occur. Also
a null backend is actually not desirable for the runtime cache which
is meant to be used as temporary per-process cache anyway.

To workaround possible issues the runtime cache is now statically
configured to use the TransientMemoryBackend if a non transient backend
(like NullBackend) has been configured.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 78

  1. Benjamin Franzke uploaded patch set 1 12/10/24, 15:38

  2. core-ci voted on patch set 1 V +1 12/10/24, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70868

  3. Benni Mack commented on patch set 1 CR +1 V +1 12/10/24, 17:07

    Yes. Much better than my other approach. At the same time, I consider NullBackend to be implement TransientBackendInterface. WDYT?
  4. Benjamin Franzke commented on patch set 1 12/11/24, 07:50

    Reply

    Yea, would be an option. but then we still have this implicit contract that `TransientBackendInterface` is currently able to return the value via get() that has been `set()` before.
  5. Benni Mack commented on patch set 1 12/11/24, 08:36

    Reply

    yeah, might have side effects which we leave out for the time being I suggest.
  6. Andreas Kienast voted on patch set 1 CR +1 V +1 12/11/24, 09:32

  7. Benjamin Franzke voted on patch set 1 CR +2 V +2 12/11/24, 15:02

  8. Benjamin Franzke merged patch set 2 12/11/24, 15:02