Review main Merged

87423[TASK] Use DI in PermissionViewHelper

Anja Leichsenring CR +2 V +2 Easy +16 −11 updated 12/11/24, 08:43

Commit message

A static cache property is replaced with an injected runtime cache
object, and so is the IconFactory along the way.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Anja Leichsenring uploaded patch set 1 12/10/24, 18:08

  2. Anja Leichsenring uploaded patch set 2 12/10/24, 18:11

  3. core-ci voted on patch set 1 V -1 12/10/24, 18:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70873

  4. core-ci voted on patch set 2 V +1 12/10/24, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70874

  5. Garvin Hicking voted on patch set 2 CR +1 12/10/24, 18:38

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 12/10/24, 20:08

  7. Georg Ringer voted on patch set 2 CR +1 V +1 12/10/24, 22:08

  8. Anja Leichsenring voted on patch set 2 CR +2 V +2 12/11/24, 08:43

  9. Anja Leichsenring merged patch set 3 12/11/24, 08:43