Review main Merged

87424[BUGFIX] Avoid type errors in DebugViewHelper

Benni Mack CR +2 V +2 Easy +8 −8 updated 12/17/24, 15:19

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1315

  1. Benni Mack uploaded patch set 1 12/10/24, 19:15

  2. core-ci voted on patch set 1 V +1 12/10/24, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70876

  3. Garvin Hicking commented on patch set 1 12/10/24, 23:07

    DebugViewHelper.php:44

    Maybe update this with a namespace example than this 4.5 era reference as drive-by?

    DebugViewHelper.php:88

    Why not (string) to convert integers like in the issue as actual output?
  4. Benni Mack commented on patch set 2 V +1 12/11/24, 09:16

    Published edit on patch set 1.
  5. Benni Mack commented on patch set 2 12/11/24, 09:16

    DebugViewHelper.php:44 Reply

    Done

    DebugViewHelper.php:88 Reply

    Done
  6. core-ci voted on patch set 2 V +1 12/11/24, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70904

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 12/11/24, 09:26

  8. Simon Schaufelberger commented on patch set 2 12/11/24, 09:42

    DebugViewHelper.php:88

    is this fix not rather fixing a symptom than the root cause? I'm expecting fluid to do the casting internally when registering the arguments. is this working properly?
  9. Christian Kuhn commented on patch set 2 12/17/24, 14:37

    DebugViewHelper.php:88 Reply

    yes: title is not declared to be a mandatory argument. fluid will not set this key in the arguments array if it is not given. changing this behavior will likely not happen anytime soon in fluid, so we have to sanitize these array accesses.

    DebugViewHelper.php:93

    this should have a null fallback as well.
  10. Christian Kuhn commented on patch set 2 12/17/24, 14:41

    DebugViewHelper.php:93 Reply

    scratch that.
  11. Christian Kuhn commented on patch set 2 12/17/24, 14:43

    DebugViewHelper.php:88 Reply

    update: arguments *not given* to fluid are initialized within $this->arguments as null, and not as the requested target type. i remember i had some discussion on with with claus back then, and there were reasons this couldn't be easily changed within fluid. i think the situation didn't change since then. so: i agree this is an underlying problem, but it hasn't been changed until now, so we have to deal with the side effects.
  12. Christian Kuhn voted on patch set 2 CR +1 V +1 12/17/24, 14:44

  13. Simon Schaufelberger voted on patch set 2 CR +1 V +1 12/17/24, 14:50

  14. Christian Kuhn voted on patch set 2 CR +2 V +2 12/17/24, 15:19

  15. Christian Kuhn merged patch set 3 12/17/24, 15:19