Review main Merged

87432[TASK] Avoid inline compilerInput parentData

Christian Kuhn CR +2 V +2 Easy +0 −4 updated 12/11/24, 12:37

Commit message

The JS side of FormEngine inline handling was rewritten
with #88182, which established a structure 'compilerInput'
transferred by inline related ajax calls from the server
side.

The key 'parentData' is sent, but never used on the client
side. The patch removes it.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 56

  1. Christian Kuhn uploaded patch set 1 12/11/24, 10:23

  2. core-ci voted on patch set 1 V +1 12/11/24, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70911

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 12/11/24, 11:58

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 12/11/24, 12:36

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 12/11/24, 12:37

  6. Christian Kuhn merged patch set 2 12/11/24, 12:37