87433[FEATURE] Introduce breadcrumb component
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 2
Files 37
- Build/Sources/Sass/component/_breadcrumb.scssnew+109 −0
- Build/Sources/Sass/component/_dropdown.scss+5 −0
- Build/Sources/Sass/component/_module.scss+10 −0
- Build/Sources/Sass/_minimal.scss+2 −1
- Build/Sources/TypeScript/backend/element/breadcrumb.ts4new+315 −0
- Build/Sources/TypeScript/backend/module-menu.ts+4 −2
- typo3/sysext/backend/Classes/Breadcrumb/BreadcrumbContext.phpnew+73 −0
- typo3/sysext/backend/Classes/Breadcrumb/BreadcrumbFactory.phpnew+222 −0
- typo3/sysext/backend/Classes/Breadcrumb/BreadcrumbProviderInterface.phpnew+61 −0
- typo3/sysext/backend/Classes/Breadcrumb/NullContextBreadcrumbProvider.phpnew+97 −0
- typo3/sysext/backend/Classes/Breadcrumb/RecordBreadcrumbProvider.phpnew+224 −0
- typo3/sysext/backend/Classes/Breadcrumb/ResourceBreadcrumbProvider.phpnew+208 −0
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+37 −7
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+8 −1
- typo3/sysext/backend/Classes/Dto/Breadcrumb/BreadcrumbNode.phpnew+52 −0
- typo3/sysext/backend/Classes/Dto/Breadcrumb/BreadcrumbNodeRoute.phpnew+43 −0
- typo3/sysext/backend/Classes/Module/ModuleResolver.phpnew+80 −0
- typo3/sysext/backend/Classes/Template/Components/Breadcrumb.php2new+123 −0
- typo3/sysext/backend/Classes/Template/Components/DocHeaderComponent.php2+81 −1
- typo3/sysext/backend/Classes/Template/Components/MetaInformation.php+2 −0
Show 17 more files
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+1 −1
- typo3/sysext/backend/Configuration/Services.yaml+10 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_layout.xlf+3 −0
- typo3/sysext/backend/Resources/Private/Partials/DocHeader.html+13 −20
- typo3/sysext/backend/Resources/Public/Css/backend.css+23 −9
- typo3/sysext/backend/Resources/Public/JavaScript/element/breadcrumb.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/module-menu.js+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/SubmoduleOverviewControllerTest.php+28 −1
- typo3/sysext/backend/Tests/Functional/Template/Components/Fixtures/BreadcrumbTestPages.csvnew+5 −0
- typo3/sysext/backend/Tests/Functional/Template/Components/BreadcrumbTest.phpnew+375 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107794-ImprovedBreadcrumbComponent.rstnew+76 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+3 −0
- typo3/sysext/filelist/Classes/Controller/FileListController.php+4 −5
- typo3/sysext/form/Classes/Controller/FormEditorController.php+6 −0
- typo3/sysext/styleguide/Classes/Controller/ComponentsController.php+67 −0
- typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf+8 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Breadcrumbs.htmlnew+101 −0
Review log 65114
Show 4889 earlier messages
-
Benjamin Kott uploaded patch set 1 12/11/24, 10:52
-
core-ci voted on patch set 1 V -1 12/11/24, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70913
-
Benjamin Kott uploaded patch set 2
V -101/07/25, 15:54 -
core-ci voted on patch set 2 V -1 01/07/25, 16:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72050
-
Benjamin Kott uploaded patch set 3
V -101/08/25, 12:24 -
core-ci voted on patch set 3 V -1 01/08/25, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72090
-
Benjamin Kott uploaded patch set 4
V -101/08/25, 16:18 -
core-ci voted on patch set 4 V -1 01/08/25, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72104
-
Benjamin Kott uploaded patch set 5
V -101/09/25, 11:56 -
core-ci voted on patch set 5 V -1 01/09/25, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72138
-
Benjamin Kott uploaded patch set 6
V -101/14/25, 16:20 -
core-ci voted on patch set 6 V -1 01/14/25, 16:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72470
-
Benjamin Kott uploaded patch set 7
V -101/15/25, 14:18 -
core-ci voted on patch set 7 V -1 01/15/25, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72529
-
Benjamin Kott uploaded patch set 8
V -101/16/25, 11:22 -
core-ci voted on patch set 8 V -1 01/16/25, 11:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72555
-
Benjamin Kott uploaded patch set 9
V -101/16/25, 15:04 -
Benjamin Kott uploaded patch set 10 01/16/25, 15:11
-
core-ci voted on patch set 9 V -1 01/16/25, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72563
-
core-ci voted on patch set 10 V -1 01/16/25, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72564
-
Benjamin Kott uploaded patch set 11
V -101/17/25, 08:07 -
Benjamin Kott uploaded patch set 12 01/17/25, 08:12
-
core-ci voted on patch set 11 V -1 01/17/25, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72597
-
Benjamin Kott uploaded patch set 13 01/17/25, 08:13
-
Benjamin Kott uploaded patch set 14 01/17/25, 08:14
-
core-ci voted on patch set 12 V -1 01/17/25, 08:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72598
-
core-ci voted on patch set 13 V -1 01/17/25, 08:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72599
-
core-ci voted on patch set 14 V -1 01/17/25, 08:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72600
-
Andreas Kienast commented on patch set 14 01/17/25, 08:41
breadcrumb.ts:298... thus this can be named `areNodesEqual`. -
Benjamin Kott uploaded patch set 15
V -101/20/25, 08:23 -
core-ci voted on patch set 15 V -1 01/20/25, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72704
-
Benjamin Kott uploaded patch set 16
V -101/20/25, 09:29 -
core-ci voted on patch set 16 V -1 01/20/25, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72713
-
Benjamin Kott uploaded patch set 17
V -101/20/25, 09:38 -
Benjamin Kott commented on patch set 16 01/20/25, 09:39
breadcrumb.ts:283ReplyDonebreadcrumb.ts:298ReplyDone -
core-ci voted on patch set 17 V -1 01/20/25, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72715
-
Benjamin Kott uploaded patch set 18
V -101/20/25, 14:36 -
core-ci voted on patch set 18 V -1 01/20/25, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72731
-
Benjamin Kott uploaded patch set 19
V -101/21/25, 13:37 -
core-ci voted on patch set 19 V -1 01/21/25, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72787
-
Benjamin Kott updated the commit message in patch set 20
V -101/22/25, 07:13 -
core-ci voted on patch set 20 V -1 01/22/25, 07:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72822
-
Andreas Kienast commented on patch set 20 01/22/25, 07:46
Interesting issue: when I expand the width of the file tree to its max and then open "Filelist" again, I get an error: > Uncaught ResizeObserver loop completed with undelivered notifications. -
Andreas Kienast commented on patch set 20 01/22/25, 08:28
Breadcrumb.php:166How can this happen? Smells like a FAL flaw?DocHeaderComponent.php:23Please no. EXT:styleguide is a dev dependency and doesn't exist in the tarball packages. -
Benjamin Kott updated the commit message in patch set 21
V -102/11/25, 12:50 -
core-ci voted on patch set 21 V -1 02/11/25, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73976
-
Benjamin Kott uploaded patch set 22
V -103/03/25, 11:39 -
Benjamin Kott uploaded patch set 23 03/03/25, 11:48
-
Benjamin Kott commented on patch set 23 03/03/25, 11:48
DocHeaderComponent.php:23ReplyDone -
core-ci voted on patch set 22 V -1 03/03/25, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75007
-
core-ci voted on patch set 23 V -1 03/03/25, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75010
-
Benjamin Kott uploaded patch set 24
V -103/06/25, 07:52 -
core-ci voted on patch set 24 V -1 03/06/25, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75206
-
Benjamin Kott uploaded patch set 25
V -105/27/25, 06:40 -
core-ci voted on patch set 25 V -1 05/27/25, 06:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79542
-
Benjamin Franzke uploaded patch set 26
V -107/25/25, 11:59 -
core-ci voted on patch set 26 V -1 07/25/25, 12:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82317
-
Benjamin Franzke uploaded patch set 27
V -107/25/25, 13:24 -
core-ci voted on patch set 27 V -1 07/25/25, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82321
-
Benjamin Franzke uploaded patch set 28
V -107/28/25, 07:11 -
core-ci voted on patch set 28 V -1 07/28/25, 07:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82408
-
Benjamin Franzke uploaded patch set 29
V -107/28/25, 07:31 -
core-ci voted on patch set 29 V -1 07/28/25, 07:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82409
-
Benjamin Franzke commented on patch set 29 07/28/25, 07:49
Breadcrumb.php:166ReplyYes, kinda, ``Folder::getParentFolder()` can only return a `Folder`, not `null`, therefore it returns `/` when retrieving the parent of `/`. For that reason the check `$parent instanceof FolderInterface` is actually a no-op (and now removed) -
Benjamin Franzke uploaded patch set 30
V -107/28/25, 07:56 -
Benjamin Franzke uploaded patch set 31 07/28/25, 08:07
-
core-ci voted on patch set 30 V +1 07/28/25, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82410
-
core-ci voted on patch set 31 V +1 07/28/25, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82411
-
Benjamin Franzke uploaded patch set 32
V +109/25/25, 11:50 -
Benjamin Franzke rebased onto patch set 33 09/25/25, 11:50
-
core-ci voted on patch set 32 V +1 09/25/25, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85508
-
core-ci voted on patch set 33 V -1 09/25/25, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85511
-
Benjamin Franzke uploaded patch set 34
V -110/06/25, 09:16 -
core-ci voted on patch set 34 V -1 10/06/25, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86067
-
Benni Mack uploaded patch set 35
V -110/17/25, 07:36 -
core-ci voted on patch set 35 V -1 10/17/25, 07:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86869
-
Benjamin Kott uploaded patch set 36
V -110/20/25, 14:25 -
core-ci voted on patch set 36 V -1 10/20/25, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87087
-
Benni Mack commented on patch set 36 10/20/25, 15:53
I need to check: - how to hand in the request object - enable breadcrumb with the resource Otherwise, I'd say, let's get this one in. -
Benni Mack uploaded patch set 37
V -110/20/25, 19:04 -
Benni Mack updated the commit message in patch set 38 10/20/25, 19:07
-
core-ci voted on patch set 37 V -1 10/20/25, 19:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87112
-
core-ci voted on patch set 38 V -1 10/20/25, 19:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87113
-
Benni Mack uploaded patch set 39
V -110/20/25, 19:30 -
core-ci voted on patch set 39 V -1 10/20/25, 19:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87116
-
Benni Mack uploaded patch set 40
V -110/20/25, 19:45 -
core-ci voted on patch set 40 V -1 10/20/25, 19:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87118
-
Benni Mack uploaded patch set 41
V -110/20/25, 20:11 -
core-ci voted on patch set 41 V +1 10/20/25, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87120
-
Benni Mack updated the commit message in patch set 42
V +110/21/25, 11:14 -
Benni Mack uploaded patch set 43 10/21/25, 11:18
-
Benni Mack voted on patch set 43 CR +1 V +1 10/21/25, 11:18
-
core-ci voted on patch set 42 V +1 10/21/25, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87175
-
core-ci voted on patch set 43 V -1 10/21/25, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87177
-
Oli Bartsch uploaded patch set 44
CR +1V +110/21/25, 12:49 -
Oli Bartsch uploaded patch set 45 10/21/25, 12:49
-
Oli Bartsch commented on patch set 45 CR -1 10/21/25, 12:49
Still checking -
core-ci voted on patch set 44 V -1 10/21/25, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87185
-
core-ci voted on patch set 45 V -1 10/21/25, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87186
-
Benjamin Franzke uploaded patch set 46
CR -1V -110/21/25, 19:45 -
core-ci voted on patch set 46 V +1 10/21/25, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87198
-
Benjamin Franzke voted on patch set 46 CR +1 V +1 10/21/25, 19:53
-
Georg Ringer voted on patch set 46 V +1 10/21/25, 20:15
-
Oli Bartsch commented on patch set 46 CR -1 10/21/25, 20:19
Please wait, still streamlining the PHP part. -
Oli Bartsch uploaded patch set 47
CR +1V +110/21/25, 21:38 -
core-ci voted on patch set 47 V -1 10/21/25, 21:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87203
-
Oli Bartsch uploaded patch set 48
V -110/22/25, 08:42 -
core-ci voted on patch set 48 V -1 10/22/25, 08:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87222
-
Oli Bartsch uploaded patch set 49
V -110/22/25, 08:52 -
core-ci voted on patch set 49 V +1 10/22/25, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87223
-
Oli Bartsch commented on patch set 49 CR +1 V +1 10/22/25, 09:01
Reply
Done -
Oli Bartsch commented on patch set 49 10/22/25, 09:08
Reply
Done -
Benni Mack commented on patch set 49 CR +2 V +2 10/22/25, 10:21
Reply
Done -
Benni Mack merged patch set 50 10/22/25, 10:21
breadcrumb.ts:283