87435[BUGFIX] Restore "Create New" buttons for inline relations with min-/maxitems
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 5
- Build/Sources/TypeScript/backend/form-engine/container/files-control-container.ts2+8 −7
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts2+1 −6
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+4 −4
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/files-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+1 −1
Review log 1320
-
Benjamin Kott uploaded patch set 1 12/11/24, 11:14
-
core-ci voted on patch set 1 V +1 12/11/24, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70917
-
Benjamin Kott uploaded patch set 2
V +112/11/24, 11:37 -
core-ci voted on patch set 2 V +1 12/11/24, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70922
-
Benjamin Kott uploaded patch set 3
V +112/11/24, 14:19 -
Benjamin Kott updated the commit message in patch set 4 12/11/24, 14:20
-
Andreas Kienast commented on patch set 4 CR +1 V +1 12/11/24, 14:30
just some nitpicksfiles-control-container.ts:568`controlContainer` cannot be null anymore, `querySelectorAll()` returns an empty NodeList if it cannot find anything.inline-control-container.ts:799`controlContainer` cannot be null anymore, `querySelectorAll()` returns an empty NodeList if it cannot find anything. -
core-ci voted on patch set 3 V +1 12/11/24, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70942
-
core-ci voted on patch set 4 V +1 12/11/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70944
-
Oli Bartsch uploaded patch set 5
CR +1V +112/16/24, 11:46 -
Oli Bartsch commented on patch set 5 CR +1 V +1 12/16/24, 11:46
files-control-container.ts:568ReplyDoneinline-control-container.ts:799ReplyDone -
core-ci voted on patch set 5 V -1 12/16/24, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71183
-
Oli Bartsch uploaded patch set 6
CR +1V +112/16/24, 12:09 -
core-ci voted on patch set 6 V +1 12/16/24, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71186
-
Oli Bartsch voted on patch set 6 CR +1 V +1 12/16/24, 12:21
-
Garvin Hicking updated the commit message in patch set 7
CR +1V +112/16/24, 13:34 -
core-ci voted on patch set 7 V +1 12/16/24, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71193
-
Garvin Hicking commented on patch set 7 CR +1 V +1 12/16/24, 13:40
Tested with EXT:styleguide > Form engine - required > "Inline" > inline_1 -
Oli Bartsch voted on patch set 7 CR +2 V +2 12/16/24, 14:49
-
Oli Bartsch merged patch set 8 12/16/24, 14:50