Review main Merged

87435[BUGFIX] Restore "Create New" buttons for inline relations with min-/maxitems

Benjamin Kott CR +2 V +2 Easy +15 −19 updated 12/16/24, 14:50

Commit message

This patch fixes a regression introduced in #105750.
For inline relations with min-/maxitems, the "Create New"
button was not correctly restored when the requirements
are met. The button is now hidden/shown correctly.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1320

  1. Benjamin Kott uploaded patch set 1 12/11/24, 11:14

  2. core-ci voted on patch set 1 V +1 12/11/24, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70917

  3. Benjamin Kott uploaded patch set 2 V +1 12/11/24, 11:37

  4. core-ci voted on patch set 2 V +1 12/11/24, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70922

  5. Benjamin Kott uploaded patch set 3 V +1 12/11/24, 14:19

  6. Benjamin Kott updated the commit message in patch set 4 12/11/24, 14:20

  7. Andreas Kienast commented on patch set 4 CR +1 V +1 12/11/24, 14:30

    just some nitpicks

    files-control-container.ts:568

    `controlContainer` cannot be null anymore, `querySelectorAll()` returns an empty NodeList if it cannot find anything.

    inline-control-container.ts:799

    `controlContainer` cannot be null anymore, `querySelectorAll()` returns an empty NodeList if it cannot find anything.
  8. core-ci voted on patch set 3 V +1 12/11/24, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70942

  9. core-ci voted on patch set 4 V +1 12/11/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70944

  10. Oli Bartsch uploaded patch set 5 CR +1 V +1 12/16/24, 11:46

  11. Oli Bartsch commented on patch set 5 CR +1 V +1 12/16/24, 11:46

    files-control-container.ts:568 Reply

    Done

    inline-control-container.ts:799 Reply

    Done
  12. core-ci voted on patch set 5 V -1 12/16/24, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71183

  13. Oli Bartsch uploaded patch set 6 CR +1 V +1 12/16/24, 12:09

  14. core-ci voted on patch set 6 V +1 12/16/24, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71186

  15. Oli Bartsch voted on patch set 6 CR +1 V +1 12/16/24, 12:21

  16. Garvin Hicking updated the commit message in patch set 7 CR +1 V +1 12/16/24, 13:34

  17. core-ci voted on patch set 7 V +1 12/16/24, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71193

  18. Garvin Hicking commented on patch set 7 CR +1 V +1 12/16/24, 13:40

    Tested with EXT:styleguide > Form engine - required > "Inline" > inline_1
  19. Oli Bartsch voted on patch set 7 CR +2 V +2 12/16/24, 14:49

  20. Oli Bartsch merged patch set 8 12/16/24, 14:50