Review main Merged

87436[DOCS] Have a better example in event listener docs

Christian Kuhn CR +2 V +2 Normal +36 −26 updated 12/11/24, 12:47

Commit message

Method injectMailSettings() used as example in the docs
is marked @internal. This should be avoided as an API
usage example. This docs change makes up a more useful
example by adding a bcc to all messages instead.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1013

  1. Christian Kuhn uploaded patch set 1 12/11/24, 11:18

  2. Christian Kuhn updated the commit message in patch set 2 12/11/24, 11:20

  3. Mathias Brodala commented on patch set 2 12/11/24, 11:25

    Feature-101544-IntroducePHPAttributeToAutoconfigureEventListeners.rst:56

    How about "AddMailMessageBcc"? This way the class name says what the class does. Right now it sounds like "BCC Mail Message" is a thing.
  4. core-ci voted on patch set 1 V +1 12/11/24, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70918

  5. core-ci voted on patch set 2 V +1 12/11/24, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70919

  6. Christian Kuhn uploaded patch set 3 V +1 12/11/24, 12:32

  7. Christian Kuhn commented on patch set 2 12/11/24, 12:32

    Feature-101544-IntroducePHPAttributeToAutoconfigureEventListeners.rst:56 Reply

    Done
  8. Mathias Brodala voted on patch set 3 CR +1 12/11/24, 12:34

  9. Stefan Bürk voted on patch set 3 CR +1 V +1 12/11/24, 12:37

  10. core-ci voted on patch set 3 V +1 12/11/24, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70925

  11. Anja Leichsenring voted on patch set 3 CR +1 V +1 12/11/24, 12:46

  12. Christian Kuhn voted on patch set 3 CR +2 V +2 12/11/24, 12:47

  13. Christian Kuhn merged patch set 4 12/11/24, 12:47