87441[BUGFIX] Ensure Indexed Search can handle PPTX and XLSX files
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1821
-
Benni Mack uploaded patch set 1 12/11/24, 12:48
-
core-ci voted on patch set 1 V +1 12/11/24, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70929
-
Xavier Perseguers voted on patch set 1 CR +1 12/11/24, 13:42
-
Christian Kuhn voted on patch set 1 CR +1 V +1 12/17/24, 14:29
-
Andreas Kienast voted on patch set 1 CR +1 12/17/24, 14:57
-
Garvin Hicking commented on patch set 1 12/17/24, 22:03
-
Benni Mack commented on patch set 1 12/18/24, 06:47
FileContentParser.php:536Replyutf8_content is set to "null" if the file ending is e.g. docx or xlsx -
Garvin Hicking commented on patch set 1 12/18/24, 06:56
FileContentParser.php:536Replybut extractPptxContent cannot return null? and the other case has its own break&cmd -
Andreas Kienast commented on patch set 1 CR 0 12/18/24, 07:01
FileContentParser.php:536ReplyGarvin is right. With `$utf8_content` never being null here as declared by `extractPptxContent()`, `$cmd` is not used in line 549. -
Benni Mack commented on patch set 1 12/18/24, 07:05
FileContentParser.php:536Replyyes. but the switch/case is in there as well.... so if the file ending is docx then $utf8_content is null, and we use the regular "extractContent" (which is CommandUtility::exec($cmd, $res); $content_xml = implode(LF, $res); unset($res); $utf8_content = trim(strip_tags(str_replace('<', ' <', $content_xml))); instead. -
Garvin Hicking commented on patch set 1 12/18/24, 07:16
FileContentParser.php:536Replyyes but the cmd used is the one in the docx switch, the potx switch cmd is never used again -
Benni Mack commented on patch set 1 12/18/24, 08:24
FileContentParser.php:536Replyah, now i see! I wonder why phpstan does not find this... -
Benni Mack commented on patch set 2
CR +1V +112/18/24, 08:25Published edit on patch set 1. -
Benni Mack commented on patch set 2 12/18/24, 08:25
FileContentParser.php:536ReplyDone -
core-ci voted on patch set 2 V -1 12/18/24, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71348
-
Benni Mack commented on patch set 3
V -112/18/24, 11:06Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 12/18/24, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71369
-
Garvin Hicking commented on patch set 3 CR +1 V +1 12/18/24, 12:58
Thank you 😅 -
Christian Kuhn voted on patch set 3 CR +1 V +1 12/19/24, 13:15
-
Benni Mack voted on patch set 3 CR +2 V +2 12/19/24, 15:02
-
Benni Mack merged patch set 4 12/19/24, 15:02
FileContentParser.php:536